Closed Bug 776669 Opened 12 years ago Closed 3 years ago

Add pinned tabs to All Tabs drop-down menu

Categories

(Firefox :: Tabbed Browser, enhancement, P5)

Product:
Firefox
Component:
Tabbed Browser
Type:
enhancement
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- wontfix
firefox83 --- wontfix
firefox84 --- wontfix
firefox85 --- wontfix
firefox86 --- wontfix
firefox87 --- wontfix
firefox92 --- fixed

People

(Reporter: GPHemsley, Assigned: cpeterson)

References

(Blocks 2 open bugs)

Details

(Keywords: blocked-ux)

Attachments

(1 file)

Bug 776669 - Add pinned tabs to the "List all tabs" drop-down list. r?dao
(deleted), text/x-phabricator-request
Details
I know they were purposely removed in bug 714594, but I don't use the All Tabs menu simply for tab overflow. I use it so that I can easily see a list of open tabs, and their (mostly) full titles. As my brain stores the location of tabs based on other tabs surrounding it, it is always confusing when I don't see the app tabs at the top of the All Tabs list. I ask that app tabs be readded to the All Tabs list. (I think it would make sense to also include bug 626854.)
Big +1 for this. Either fix it or change the tooltip to "List some but not all tabs" =)
Why not actually fix bug 626854 too while at it?
Type: defect → enhancement
Keywords: blocked-ux
Priority: -- → P5
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1494755
Summary: Add App Tabs to All Tabs drop-down menu → Add pinned tabs to All Tabs drop-down menu
Blocks: pinnedtabs

Hi Dão, I see there are plans for a new Tab Manager design (bug 1494755). Will Proton include that new Tab Manager design? In the meantime, would you accept a trivial fix for this bug to include pinned tabs in the Tab Manager's drop-down list?

If so, are there existing tests for the Tab Manager that should be updated? I see a browser_tab_manager_visibility.js test, but it only tests whether the Tab Manager button is visible, not whether the drop-down list contains the correct information.

Would you accept a patch to fix bug 626854 ("Add a separator after pinned tabs in the drop-down list")? You WONTFIX'd that bug 9 years ago. :)

Would you accept a patch to always enable the Tab Manager (change browser.tabs.tabmanager.enabled pref default to true)? Currently, the Tab Manager button only appears if I open >= 17 tabs on a maximized browser window on my MacBook Pro. I find the Tab Manager helpful even with fewer tabs open because the drop-down list shows the full page titles. (The browser.tabs.tabmanager.enabled pref was added in bug 1480542.)

Assignee: nobody → cpeterson
Severity: normal → S3
Points: --- → 1
status-firefox83: --- → wontfix
status-firefox84: --- → wontfix
status-firefox85: --- → ?
status-firefox-esr78: --- → wontfix
Flags: needinfo?(dao+bmo)

are there existing tests for the Tab Manager that should be updated? I see a browser_tab_manager_visibility.js test, but it only tests whether the Tab Manager button is visible, not whether the drop-down list contains the correct information.

Here's a Try run of my patch. There are quite a few random test failures :( but none of them look related to the Tab Manager. :)

https://treeherder.mozilla.org/jobs?repo=try&revision=f66271d1410d1878427cd474502ed35ccbfe6767

(In reply to Chris Peterson [:cpeterson] from comment #4)

Hi Dão, I see there are plans for a new Tab Manager design (bug 1494755). Will Proton include that new Tab Manager design?

I have no idea. As far as I know UX folks are still in the drawing-board stage.

In the meantime, would you accept a trivial fix for this bug to include pinned tabs in the Tab Manager's drop-down list?

I would with explicit UX approval.

Would you accept a patch to fix bug 626854 ("Add a separator after pinned tabs in the drop-down list")? You WONTFIX'd that bug 9 years ago. :)

It was wontfixed because we went a different direction for good reasons. Certainly we can reverse course for other good reasons, but I think this should be part of a holistic approach such as the Tab Manager design.

Would you accept a patch to always enable the Tab Manager (change browser.tabs.tabmanager.enabled pref default to true)?

I would with explicit UX/product approval. I suspect we'd want to finish implementing the whole proposal though.

Flags: needinfo?(dao+bmo)

verdi, can you please take a look at this bug, the last few comments in particular, and let me know what you think about cpeterson's questions?

Flags: needinfo?(mverdi)

(In reply to Dão Gottwald [::dao] from comment #8)

verdi, can you please take a look at this bug, the last few comments in particular, and let me know what you think about cpeterson's questions?

Verdi, what is your UX opinion on this bug to stop excluding pinned tabs from the (so-called) "All Tabs" drop down menu?

You can the other questions in my comment 4. At this time, the only change I'd like to make is including pinned tabs in the "All Tabs" drop down menu.

status-firefox85: ? → wontfix
status-firefox86: --- → wontfix
status-firefox87: --- → fix-optional
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1781844682c3 Add pinned tabs to the "List all tabs" drop-down list. r=dao

https://hg.mozilla.org/mozilla-central/rev/1781844682c3

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
status-firefox87: fix-optional → wontfix
Flags: needinfo?(mverdi)

Would it be possible to add a toggle in about:config if pinned tabs should be included in the "All tabs" drop-down or not? I have usually around 60~70 tabs open, about 30 of them pinned and now with all tabs showing in the "All tabs" menu it involves quite a lot of scrolling since I need to scroll through my pinned tabs, which I'm seeing anyways to get to the unpinned ones. :(

Thanks for considering!

Blocks: 1730415
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: