This removes more addVisit calls in Places tests.

Easy changes here, though an indentation change makes the patch larger. In one test, promises are used to wait for two asynchronous events regardless of the order they are notified.

Comment on attachment 683515 [details] [diff] [review] Updated patch Review of attachment 683515 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/places/tests/bookmarks/test_async_observers.js @@ +74,5 @@ > PlacesUtils.bookmarks.addObserver(observer, false); > > +add_task(function test_add_visit() > +{ > + let observerPromise = observer.reset(); Ok, so .reset looks like the wrong name now... maybe .prepare(), .setup(), or .init()? ::: toolkit/components/places/tests/bookmarks/test_nsINavBookmarkObserver.js @@ +290,5 @@ > { name: "guid", check: function (v) typeof(v) == "string" && /^[a-zA-Z0-9\-_]{12}$/.test(v) }, > { name: "parentGuid", check: function (v) typeof(v) == "string" && /^[a-zA-Z0-9\-_]{12}$/.test(v) }, > ] }, > ]; > + addVisits({ uri: uri, transition: TRANSITION_TYPED }); just use promiseAddvisits, I'd like to remove addVisits at a certain point, to have just one util