Heather Arthur [:harth] Reporter
	Description • 12 years ago

A bunch of websites use hashes in their CSS file names apparently. The screenshot here is from Github. This forces a horizontal scrollbar in the rule view.

It looks like Chrome solves this by cutting the url off. Another idea: we throw an ellipsis in the middle like "github-cf328ed...8294cb.css". We should also show the full name in a tooltip and enable copying the link location from the context menu.

	Paul Rouget [:paul]
	Comment 1 • 12 years ago

Bug triage, filter on PINKISBEAUTIFUL

	David Creswick Assignee
	Comment 2 • 12 years ago

The dependency between this bug and bug 831711 should be reversed. (Right?)

	David Creswick Assignee
	Comment 3 • 12 years ago

This patch puts an ellipsis in the middle and adds tooltips.

	Paul Rouget [:paul]
	Comment 4 • 12 years ago

Thank you David. Can I ask you to rebase your patch on the current tree? We made a lot of changes lately on the Rule View.

	David Creswick Assignee
	Comment 5 • 12 years ago

No problem. Rebased, as requested.

	Joe Walker [:jwalker]
	Comment 6 • 12 years ago

Comment on attachment 730844 [details] [diff] [review]
patch v2, rebased

Paul is on vacation, I'll do it.

	Joe Walker [:jwalker]
	Comment 7 • 12 years ago

Thanks David. I'll add this to my land list.

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 8 • 12 years ago

https://hg.mozilla.org/integration/fx-team/rev/0289f7473afa

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 9 • 12 years ago

https://hg.mozilla.org/integration/fx-team/rev/d14c0b0326b7

Backed out for test failures:

https://tbpl.mozilla.org/php/getParsedLog.php?id=21638227&tree=Fx-Team

	David Creswick Assignee
	Comment 10 • 12 years ago

Those failures aren't caused by this patch. I get those failures locally, independent of whether this patch is applied. The tests browser_ruleview_editor_changedvalues.js and browser_ruleview_ui.js timeout waiting for focus. The funny thing is that I get timeouts when I run it inside xvfb, but the tests succeed when I run them outside in the real X server.

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 11 • 12 years ago

They were failing in all Windows and OS X build configurations and the failures stopped after the backout. You can't argue with that :-)

I don't get any of these failures locally, so if you do, you already are in a good position to debug this!

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 13 • 12 years ago

Try run:
https://tbpl.mozilla.org/?tree=Try&rev=2ff490c76e42

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 14 • 12 years ago

Try is green. Is this ready to reland ro do you need another review? Can you describe the changes in this version?

	David Creswick Assignee
	Comment 15 • 12 years ago

The original patch seems to have changed the layout enough to cause the tests' mouse click event to miss the element in a not-reproducible-on-every-platform way. My solution was to offset the location of the click event some more to cause it to hit the text reliably once again.

	Paul Rouget [:paul]
	Comment 16 • 12 years ago

> in a not-reproducible-on-every-platform way

All platforms don't have the same resolution and screen size. That might explain why.

	David Creswick Assignee
	Comment 17 • 12 years ago

So I suppose this is ready to land?

	Joe Walker [:jwalker]
	Comment 18 • 12 years ago

Added to my list of things to land unless anyone else gets there first.

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 19 • 12 years ago

https://hg.mozilla.org/integration/fx-team/rev/eaeff37cbffc

	Phil Ringnalda (:philor)
	Comment 20 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/eaeff37cbffc