Closed
Bug 777687
Opened 12 years ago
Closed 12 years ago
make handling of broken %-escapes in RFC2231/5987 encoding more draconian
Categories
(Core Graveyard :: File Handling, defect)
Core Graveyard
File Handling
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla20
People
(Reporter: julian.reschke, Assigned: julian.reschke)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
jduell.mcbugs
:
review+
|
Details | Diff | Splinter Review |
Test cases:
http://greenbytes.de/tech/tc2231/#attwithfn2231nbadpct1
and
http://greenbytes.de/tech/tc2231/#attwithfn2231nbadpct2
The values contain "%" characters that do not start a %hh sequence. Safari 6 now implements RFC 5987 and treats these encoding errors as fatal (so has Konqueror for some time).
Firefox should match this behavior.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → julian.reschke
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #646423 -
Flags: review?(jduell.mcbugs)
Assignee | ||
Comment 2•12 years ago
|
||
Patch updated to apply to latest trunk; try results at https://tbpl.mozilla.org/?tree=Try&rev=28e559bfc67a
Attachment #646423 -
Attachment is obsolete: true
Attachment #646423 -
Flags: review?(jduell.mcbugs)
Attachment #686064 -
Flags: review?(jduell.mcbugs)
Assignee | ||
Comment 3•12 years ago
|
||
Patch updated to apply to latest trunk; try results at https://tbpl.mozilla.org/?tree=Try&rev=325e5cfbe50d (this patch differs from the previous only in whitespace removal)
Attachment #686064 -
Attachment is obsolete: true
Attachment #686064 -
Flags: review?(jduell.mcbugs)
Attachment #686083 -
Flags: review?(jduell.mcbugs)
Comment 4•12 years ago
|
||
Comment on attachment 686083 [details] [diff] [review]
Proposed patch, incl test case
Review of attachment 686083 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good.
https://hg.mozilla.org/integration/mozilla-inbound/rev/575d6637b9f1
thanks Julian!
Attachment #686083 -
Flags: review?(jduell.mcbugs) → review+
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Comment 6•12 years ago
|
||
Comment on attachment 686083 [details] [diff] [review]
Proposed patch, incl test case
Review of attachment 686083 [details] [diff] [review]:
-----------------------------------------------------------------
::: netwerk/mime/nsMIMEHeaderParamImpl.cpp
@@ +146,5 @@
> +
> +// validate that a C String containing %-escapes is syntactically valid
> +bool IsValidPercentEscaped(const char *aValue, PRInt32 len)
> +{
> + for (PRInt32 i = 0; i < len; i++) {
Hey guys, for future reference, this needs to use int32_t (though uint32_t is actually more appropriate).
Assignee | ||
Comment 7•12 years ago
|
||
(In reply to :Ms2ger from comment #6)
> Hey guys, for future reference, this needs to use int32_t (though uint32_t
> is actually more appropriate).
Citation needed. (Always willing to learn...)
Comment 8•12 years ago
|
||
> Citation needed.
bug 579517.
I've fixed this--thanks for heads-up ms2ger.
https://hg.mozilla.org/integration/mozilla-inbound/rev/972aa16a72e7
Comment 9•12 years ago
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•