Closed
Bug 777842
Opened 12 years ago
Closed 12 years ago
Make Marionette Python 2.6 compatible
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla17
People
(Reporter: jgriffin, Assigned: automatedtester)
References
Details
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
automatedtester
:
review+
|
Details | Diff | Splinter Review |
In order to run in TBPL, Marionette will need to be Python 2.6 compatible. We can omit running it on OSX 10.5, which would require Python 2.5 compatibility.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → dburns
Assignee | ||
Comment 1•12 years ago
|
||
The 2 items removed were added with Python 2.7. Since we don't appear to be using them, as far as I can see I removed them.The other alternative is to wrap them in a try except
Attachment #646327 -
Flags: review?(jgriffin)
Reporter | ||
Comment 2•12 years ago
|
||
What about expectedFailures and unexpectedSuccesses (e.g., http://mxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/runtests.py#117)? These seem to have been introduced in Python 2.7.
Assignee | ||
Comment 3•12 years ago
|
||
expectedFailures and unexpectedSuccesses are part of 2.6 however skipped isnt (
http://docs.python.org/library/unittest.html#unittest.TestResult.skipped) will update patch
Assignee | ||
Comment 4•12 years ago
|
||
removed skipped and code to do with it.
Attachment #646327 -
Attachment is obsolete: true
Attachment #646327 -
Flags: review?(jgriffin)
Attachment #646495 -
Flags: review?(jgriffin)
Reporter | ||
Comment 5•12 years ago
|
||
Comment on attachment 646495 [details] [diff] [review]
Allow tests to work with python 2.6 V2
I'd rather not strip out support for skipped/todo tests just to appease Python 2.6; I think it would be better to implement support in Marionette for this so it will work with Python 2.6, which probably means porting some of the stdlib stuff into MarionetteTestResult and MarionetteTextTestRunner.
Attachment #646495 -
Flags: review?(jgriffin) → review-
Reporter | ||
Comment 6•12 years ago
|
||
I took at this and think it's too much trouble to try and backport support for skipped/expectedFailures/unexpectedSuccesses. So this patch fixes things so they won't break with Python 2.6, and I think we can implement support for skipped, etc using the test manifests in a separate patch
Attachment #651052 -
Flags: review?(dburns)
Reporter | ||
Updated•12 years ago
|
Attachment #646495 -
Attachment is obsolete: true
Reporter | ||
Comment 7•12 years ago
|
||
Ok, the last patch was *really* dumb wrt to failure count in the XML generator. This one isn't.
Attachment #651056 -
Flags: review?(dburns)
Reporter | ||
Updated•12 years ago
|
Attachment #651052 -
Attachment is obsolete: true
Attachment #651052 -
Flags: review?(dburns)
Assignee | ||
Comment 8•12 years ago
|
||
Comment on attachment 651056 [details] [diff] [review]
make Marionette Python2.6 compatible
looks good to me
Attachment #651056 -
Flags: review?(dburns) → review+
Reporter | ||
Comment 9•12 years ago
|
||
Target Milestone: --- → mozilla17
Comment 10•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•