Dave Camp (:dcamp) Reporter
	Description • 12 years ago

When bug 753517 lands, CssRuleView.jsm can go back to using WeakMaps for edited properties.

	Andrew McCreight [:mccr8]
	Comment 1 • 12 years ago

This actually needs to depend on another bug, because we have to change what we allow.  That bug in turn depends on bug 753517.  For now, I'll call it bug 777385, though that isn't quite right.

	Andrew McCreight [:mccr8]
	Comment 2 • 12 years ago

Hmm.  I forgot about this. I'll look into how we can add support for these style things this week.

	Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]
	Comment 3 • 12 years ago

Now that bug 753517 is fixed, the map in UserProperties() should be switched back to a WeakMap.

Search for

	Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]
	Comment 4 • 12 years ago

Search for 753517 in CssRuleView.jsm.

	David Creswick Assignee
	Comment 5 • 12 years ago

Is this any more involved than just doing the inverse of the patch from Bug 777373? If there's more to it than that, I volunteer myself to work on it.

	Joe Walker [:jwalker]
	Comment 6 • 12 years ago

(In reply to David Creswick from comment #5)
> Is this any more involved than just doing the inverse of the patch from Bug
> 777373? If there's more to it than that, I volunteer myself to work on it.

I don't think there's more to it. Thanks for offering. Assigned.

	Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]
	Comment 8 • 12 years ago

Comment on attachment 733400 [details] [diff] [review]
patch

Review of attachment 733400 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r+.

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 9 • 12 years ago

https://hg.mozilla.org/integration/fx-team/rev/ec873217d6e2

	Ryan VanderMeulen [:RyanVM]
	Comment 10 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/ec873217d6e2