Closed
Bug 777891
Opened 12 years ago
Closed 12 years ago
Watcher requires internet permission to work on Pandas
Categories
(Testing Graveyard :: SUTAgent, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla17
People
(Reporter: wlach, Assigned: wlach)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Not sure about earlier versions, but watcher's invocation of the "ping" command will only work if the application is given internet permissions. Easy to fix.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #646297 -
Flags: review?(jmaher)
Assignee | ||
Updated•12 years ago
|
Blocks: android_4.0_testing
Comment 2•12 years ago
|
||
Comment on attachment 646297 [details] [diff] [review]
Patch to add internet permissions to watcher
Review of attachment 646297 [details] [diff] [review]:
-----------------------------------------------------------------
can we test this on tegra and panda boards before deployment?
Attachment #646297 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to Joel Maher (:jmaher) from comment #2)
> Comment on attachment 646297 [details] [diff] [review]
> Patch to add internet permissions to watcher
>
> Review of attachment 646297 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> can we test this on tegra and panda boards before deployment?
I've already tested this on the panda. I don't have a tegra to test with but I also don't see why it would break -- we give the exact same permission to the main SUTAgent and it works fine.
Comment 4•12 years ago
|
||
oh, fair enough. Just wanted to make sure old fashioned Android 2.x works with that permission.
Assignee | ||
Comment 5•12 years ago
|
||
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Updated•7 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•