Closed
Bug 778195
Opened 12 years ago
Closed 12 years ago
DrawTargetCairo.cpp:764: error: 'memcpy' was not declared in this scope
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: romaxa, Assigned: romaxa)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
I guess string.h is missing for memcpy...
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → romaxa
Attachment #646616 -
Flags: review?(ncameron)
Assignee | ||
Updated•12 years ago
|
Attachment #646616 -
Flags: review?(ncameron) → review?(jmuizelaar)
Comment 2•12 years ago
|
||
Comment on attachment 646616 [details] [diff] [review]
Add string.h to cover memcpy include
Please put <string.h> above the local includes
Attachment #646616 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 3•12 years ago
|
||
Thanks for fixing this. Could you give more details about the error, in particular which platform it showed up on? And why this wasn't caught by our build bots? Thanks!
Comment 4•12 years ago
|
||
Also, I know we have problems including some of the standard libraries on mac, does that include string.h?
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/74c9c20b284a
Romaxa, please make sure that qnew = -U is set in your .hgrc [defaults] section.
Flags: in-testsuite-
Keywords: checkin-needed
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Comment 7•12 years ago
|
||
And please address review comments...
Assignee | ||
Comment 8•12 years ago
|
||
(In reply to Nick Cameron [:nrc] from comment #3)
> Thanks for fixing this. Could you give more details about the error, in
> particular which platform it showed up on? And why this wasn't caught by our
> build bots? Thanks!
For me it fails to build on Maemo/Meego and ubuntu arm oneiric (linux)
You need to log in
before you can comment on or make changes to this bug.
Description
•