Andrew Halberstadt [:ahal] Assignee
	Description • 12 years ago

Looking through the logs while running reftests in b2g (see https://wiki.mozilla.org/B2G/Hacking#Reftests) there are several "program error managing snapshot" failures.

There is no test name associated with these errors, though it does seem to prevent the test from running. There's a very good chance this is caused by something I did to the harness to get it working in B2G in the first place.

	Andrew Halberstadt [:ahal] Assignee
	Comment 1 • 12 years ago

In reftest.js -> RecordResult():
    if (gURLs[0]["prefSettings" + gState].length == 0 &&
        gURICanvases[gCurrentURL]) {
        gCurrentCanvas = gURICanvases[gCurrentURL];
    }
    if (gCurrentCanvas == null) {
        gDumpLog("REFTEST TEST-UNEXPECTED-FAIL | | program error managing snapshots\n");
        ++gTestResults.Exception;
    }

	Andrew Halberstadt [:ahal] Assignee
	Comment 2 • 12 years ago

Ugh, so I think this was caused by me doing something hacky to get the reftests working initially and then forgetting to go back and fix it properly afterwards. Doing some more testing, but should have a patch soon.

	Andrew Halberstadt [:ahal] Assignee
	Comment 3 • 12 years ago

Completely forgot that I had done this hack. This will get rid of the of the program error managing snapshot messages, though I don't think it will fix any of the tests that were failing previously (though one can hope!)

	Jonathan Griffin (:jgriffin)
	Comment 4 • 12 years ago

Comment on attachment 652238 [details] [diff] [review]
Patch 1.0 - Fix prggram error managing snapshots error

Review of attachment 652238 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

	Jonathan Griffin (:jgriffin)
	Comment 5 • 12 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/f6dd071e8ff9

	Ed Morley [:emorley]
	Comment 6 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/f6dd071e8ff9