This morning I was listening to a podcast where they mentioned that a code search for "lenght" (instead of "length") got a lot of hits, so out of curiosity, I ran it on our code base. The only hit that seemed to make any difference was this one.

Comment on attachment 647516 [details] [diff] [review] A patch for the most-likely-to-be-a-bug occurence of lenght. Ted, you reviewed the patch that added this line. Did you want to review this one, too? Thanks, Blake.

Comment on attachment 647516 [details] [diff] [review] A patch for the most-likely-to-be-a-bug occurence of lenght. I don't, but jesup could. (This looks obviously correct to me, FWIW.)

This should be submitted as an upstream bug to webrtc.org, where that code comes from (and might already be corrected). Please note the Issue number/link here, so we can track the upstream issue, and close it once we import a fix (unless we need to (and sometimes we do), I prefer not to land fixes to upstream code directly here, since we then have to resolve conflicts when they update). As this would invoke a compiler error, I believe no current platform we've being compiling for triggers this problem. Thanks for digging in!

Comment on attachment 647516 [details] [diff] [review] A patch for the most-likely-to-be-a-bug occurence of lenght. r+, but please do not check it into m-c at this time per previous comment

I poked around a little, but I'm afraid that the Contributor Agreement they have, and the lack of a clear link to their bug tracker, exceeded the threshold of my caring. :) If you know how to move it forward (and are interested), please feel free to. If it helps, I'm happy to release the patch I attached into the public domain, or assign copyright of it to whomever. Thanks, Blake.

So, has this bug been fixed in our tree?

(I'm not actually working on this, so if it hasn't been fixed, I'll let someone else take it.)

Pawned off to upstream bug (still not fixed); this is test code we don't actually use.