Closed
Bug 779123
Opened 12 years ago
Closed 12 years ago
nsDocShell::GetExtendedOrigin returns false instead of NS_OK
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: ayg, Assigned: ayg)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
Bug 776140 added nsDocShell::GetExtendedOrigin, with return value NS_IMETHODIMP. But it has "NS_ENSURE_TRUE(ssmgr, false)". This is identical to "NS_ENSURE_TRUE(ssmgr, NS_OK)", but possibly not intended, and at any rate confusing. Either it should return some type of error, or use NS_OK instead of false.
|
Assignee | |
Comment 1•12 years ago
|
||
This is equivalent to the current code, except that it will still work once bug 777292 lands, but was the intent to actually return an error?
Assignee: jduell.mcbugs → ayg
Attachment #647889 -
Flags: review?
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 647889 [details] [diff] [review]
Patch, changes false to NS_OK
Sigh, back+forward clears autocomplete=off fields like requestee . . .
Attachment #647889 -
Flags: review? → review?(justin.lebar+bug)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 647889 [details] [diff] [review]
Patch, changes false to NS_OK
It was likely intended to return an error; can you change it to NS_ERROR_FAILURE?
Attachment #647889 -
Flags: review?(justin.lebar+bug) → review+
|
||
Comment 4•12 years ago
|
||
Yes, it should return NS_ERROR_FAILURE.
|
|
Assignee | |
Comment 5•12 years ago
|
||
Flags: in-testsuite-
Target Milestone: --- → mozilla17
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•