Closed
Bug 779302
Opened 12 years ago
Closed 12 years ago
speed up arrow panel opening animation
Categories
(Toolkit :: Themes, enhancement)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla17
Tracking | Status | |
---|---|---|
firefox16 | --- | fixed |
People
(Reporter: asa, Assigned: dao)
References
Details
(Whiteboard: [good first bug][mentor=jaws][lang=css])
Attachments
(1 file)
(deleted),
patch
|
shorlander
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The arrow panel animations are nice, but they're too slow. We need the panel to fade in a bit faster and the slide-down to happen in about half the current time (estimates from me, shorlander, and jaws)
Comment 1•12 years ago
|
||
The changes to the times would be made here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/pinstripe/global/popup.css#31
and here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/global/popup.css#39
Whiteboard: [good first bug][mentor=jaws][lang=css]
Version: unspecified → 17 Branch
Assignee | ||
Comment 2•12 years ago
|
||
125ms for the sliding looked weirdly jumpy, but 150ms seems to work fine. Tested on Windows.
Assignee | ||
Updated•12 years ago
|
Summary: speed up arrow panel animation → speed up arrow panel opening animation
Version: 17 Branch → Trunk
Assignee | ||
Updated•12 years ago
|
Comment 3•12 years ago
|
||
Comment on attachment 647778 [details] [diff] [review]
patch
Review of attachment 647778 [details] [diff] [review]:
-----------------------------------------------------------------
This feels more responsive. Thank you!
Attachment #647778 -
Flags: review?(shorlander) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 4•12 years ago
|
||
Comment 5•12 years ago
|
||
Comment on attachment 647778 [details] [diff] [review]
patch
[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature in bug 767133 & bug 767861
User impact if declined: arrow panels (doorhangers, bookmarks properties) will open slower than desired
Testing completed (on m-c, etc.): tested locally, just landed on inbound
Risk to taking this patch (and alternatives if risky): no risk
String or UUID changes made by this patch: none
Attachment #647778 -
Flags: approval-mozilla-aurora?
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 7•12 years ago
|
||
Comment on attachment 647778 [details] [diff] [review]
patch
fixes for a new feature in 16, approving for aurora.
Attachment #647778 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•12 years ago
|
||
status-firefox16:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•