Closed Bug 779732 Opened 12 years ago Closed 12 years ago

Make search operations in the debugger more intuitive

Categories

(DevTools :: Debugger, defect, P2)

12 Branch
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 18

People

(Reporter: vporof, Assigned: vporof)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(2 files, 3 obsolete files)

We're currently relying on operators for searching scripts, tokens etc. These are hard to discover (even if documented somewhere). It would be a good idea to have some UI for this, like a dropdown menu for search or something more fancy.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P3
Priority: P3 → P2
Attached patch v1 (obsolete) (deleted) — Splinter Review
Attachment #655574 - Flags: review?(rcampbell)
Attached image screenshot (obsolete) (deleted) —
Pretty panels!
Attachment #655576 - Flags: feedback?(shorlander)
Should probably append some key shortcuts info on those strings. Can totally follow up for this.
(In reply to Victor Porof [:vp] from comment #4) > Should probably append some key shortcuts info on those strings. > Can totally follow up for this. Filed bug 785889.
Depends on: 785650
Blocks: 785883
Blocks: 785889
Attached patch v1.1 (deleted) — Splinter Review
Making sure this is the latest patch.
Attachment #655574 - Attachment is obsolete: true
Attachment #655574 - Flags: review?(rcampbell)
Attachment #655906 - Flags: review?(rcampbell)
Comment on attachment 655906 [details] [diff] [review] v1.1 + _onScriptsSearchClick: function DVS__onScriptsSearchClick() { + // If the webpage has no scripts, searching is redundant. + if (!this._scripts.itemCount) { + return; + } might this be confusing? If a user clicks there expecting to see the helpful popup, they won't know why it isn't there. looks good!
Attachment #655906 - Flags: review?(rcampbell) → review+
(In reply to Rob Campbell [:rc] (:robcee) from comment #8) > Comment on attachment 655906 [details] [diff] [review] > v1.1 > > + _onScriptsSearchClick: function DVS__onScriptsSearchClick() { > + // If the webpage has no scripts, searching is redundant. > + if (!this._scripts.itemCount) { > + return; > + } > > might this be confusing? If a user clicks there expecting to see the helpful > popup, they won't know why it isn't there. > > looks good! But then again, seeing it may suggest that they have something to search for? Anyway, pretty remote case imo. You don't see people debugging pages without scripts very often.
yeah. Maybe best to just ditch that check altogether. Fewer lines ftw!
Attached patch v1.2 [land-me] (obsolete) (deleted) — Splinter Review
Attachment #656274 - Attachment description: v1.2 → v1.2 [land-me]
Attached patch v1.3 (deleted) — Splinter Review
Rebased
Attachment #655576 - Attachment is obsolete: true
Attachment #656274 - Attachment is obsolete: true
Attachment #655576 - Flags: feedback?(shorlander)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: