Closed
Bug 779732
Opened 12 years ago
Closed 12 years ago
Make search operations in the debugger more intuitive
Categories
(DevTools :: Debugger, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 18
People
(Reporter: vporof, Assigned: vporof)
References
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(2 files, 3 obsolete files)
(deleted),
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
We're currently relying on operators for searching scripts, tokens etc. These are hard to discover (even if documented somewhere). It would be a good idea to have some UI for this, like a dropdown menu for search or something more fancy.
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P3
Assignee | ||
Updated•12 years ago
|
Priority: P3 → P2
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #655574 -
Flags: review?(rcampbell)
Assignee | ||
Comment 3•12 years ago
|
||
Should probably append some key shortcuts info on those strings.
Can totally follow up for this.
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Victor Porof [:vp] from comment #4)
> Should probably append some key shortcuts info on those strings.
> Can totally follow up for this.
Filed bug 785889.
Assignee | ||
Comment 5•12 years ago
|
||
Assignee | ||
Comment 6•12 years ago
|
||
Making sure this is the latest patch.
Attachment #655574 -
Attachment is obsolete: true
Attachment #655574 -
Flags: review?(rcampbell)
Attachment #655906 -
Flags: review?(rcampbell)
Comment 7•12 years ago
|
||
Comment on attachment 655906 [details] [diff] [review]
v1.1
+ _onScriptsSearchClick: function DVS__onScriptsSearchClick() {
+ // If the webpage has no scripts, searching is redundant.
+ if (!this._scripts.itemCount) {
+ return;
+ }
might this be confusing? If a user clicks there expecting to see the helpful popup, they won't know why it isn't there.
looks good!
Attachment #655906 -
Flags: review?(rcampbell) → review+
Assignee | ||
Comment 8•12 years ago
|
||
(In reply to Rob Campbell [:rc] (:robcee) from comment #8)
> Comment on attachment 655906 [details] [diff] [review]
> v1.1
>
> + _onScriptsSearchClick: function DVS__onScriptsSearchClick() {
> + // If the webpage has no scripts, searching is redundant.
> + if (!this._scripts.itemCount) {
> + return;
> + }
>
> might this be confusing? If a user clicks there expecting to see the helpful
> popup, they won't know why it isn't there.
>
> looks good!
But then again, seeing it may suggest that they have something to search for?
Anyway, pretty remote case imo. You don't see people debugging pages without scripts very often.
Comment 9•12 years ago
|
||
yeah. Maybe best to just ditch that check altogether. Fewer lines ftw!
Assignee | ||
Comment 10•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #656274 -
Attachment description: v1.2 → v1.2 [land-me]
Assignee | ||
Comment 11•12 years ago
|
||
Rebased
Attachment #655576 -
Attachment is obsolete: true
Attachment #656274 -
Attachment is obsolete: true
Attachment #655576 -
Flags: feedback?(shorlander)
Assignee | ||
Comment 12•12 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Comment 13•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•12 years ago
|
Target Milestone: --- → Firefox 18
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•