Closed
Bug 779940
Opened 12 years ago
Closed 12 years ago
Add a layers transactions meter
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: cjones, Assigned: mattwoodrow)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
We've had some bugs where we were sending way too many layers transactions, but the throttling of composition was hiding those bugs. Matt added a second rate counter for layers transactions, in addition to the compositor counter. I'd like to land that.
Reporter | ||
Comment 1•12 years ago
|
||
Attachment #648557 -
Flags: review?(jones.chris.g)
Reporter | ||
Comment 2•12 years ago
|
||
Comment on attachment 648557 [details] [diff] [review]
Meter layers transactions in addition to composites
>diff --git a/gfx/layers/Layers.h b/gfx/layers/Layers.h
>+ virtual void NotifyContentUpdated() {}
More precisely: |NotifyShadowTreeTransaction()|. I would prefer to
stick this method on ShadowLayerManager if it's not too inconvenient.
>diff --git a/gfx/layers/ipc/CompositorParent.cpp b/gfx/layers/ipc/CompositorParent.cpp
> void
>+CompositorParent::ContentUpdated()
Similarly, |NotifyShadowTreeTransaction()|.
>@@ -861,16 +868,17 @@ CompositorParent::ShadowLayersUpdated(Sh
> ScheduleComposition();
>+ mLayerManager->NotifyContentUpdated();
Should this just call NotifyShadowTreeTransaction().
>diff --git a/gfx/layers/opengl/LayerManagerOGL.cpp b/gfx/layers/opengl/LayerManagerOGL.cpp
>+void
>+LayerManagerOGL::FPSState::ContentUpdated()
And here.
r=me with that. Will file followup for ... interesting ... fps
calculation.
Attachment #648557 -
Flags: review?(jones.chris.g) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Fixed review comments, carrying forward r=cjones
Attachment #648557 -
Attachment is obsolete: true
Attachment #649525 -
Flags: review+
Assignee | ||
Comment 4•12 years ago
|
||
Assignee: nobody → matt.woodrow
Comment 5•12 years ago
|
||
Sorry, I had to back this out because it caused all native Android tests runs to crash/timeout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a525ac9349eb
Reporter | ||
Comment 6•12 years ago
|
||
I noticed that in
void
+CompositorParent::NotifyShadowTreeTransaction()
+{
+ ShadowLayerManager *shadow = mLayerManager->AsShadowManager();
+ if (shadow) {
+ shadow->NotifyShadowTreeTransaction();
+ }
+ ScheduleComposition();
+}
we don't check if mLayerManager is null, which Composite() does.
Reporter | ||
Comment 7•12 years ago
|
||
Reporter | ||
Comment 8•12 years ago
|
||
Reporter | ||
Comment 9•12 years ago
|
||
Andreas, if the try run in comment 7 comes back green while I'm in the air, this would be great to land before the work week to help with perf analysis.
Reporter | ||
Comment 10•12 years ago
|
||
Comment 11•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•