Closed
Bug 780047
Opened 12 years ago
Closed 12 years ago
Prevent mozbrowsers from using PBrowser:CreateWindow
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
People
(Reporter: cjones, Assigned: justin.lebar+bug)
References
Details
Attachments
(1 file)
(deleted),
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
This is a "legacy" interface we implemented for xul-fennec. We should ensure that PBrowsers opened for mozbrowser treat those requests as malicious attacks. Should block because I'm pretty sure OpenWindow is fully trusted and would allow bad things to happen ...
Updated•12 years ago
|
blocking-basecamp: ? → +
Assignee | ||
Comment 2•12 years ago
|
||
Chris, there is no PBrowser::OpenWindow, nor did such a method ever exist, as far as I can tell. Can you help me find the method you're referring to here?
Reporter | ||
Comment 3•12 years ago
|
||
http://mxr.mozilla.org/mozilla-central/source/dom/ipc/PBrowser.ipdl#79
Summary: Prevent mozbrowsers from using PBrowser:OpenWindow → Prevent mozbrowsers from using PBrowser:CreateWindow
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #655824 -
Flags: review?(jones.chris.g)
Reporter | ||
Comment 5•12 years ago
|
||
Comment on attachment 655824 [details] [diff] [review] Patch, v1 Now that xul-fennec is de-supported, I'd love to take a hatchet to this. Except I think metro inherited all that code. All the same, filing a followup on excising this would make me happy.
Attachment #655824 -
Flags: review?(jones.chris.g) → review+
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6cc3b189dcf
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e6cc3b189dcf
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Updated•12 years ago
|
Component: DOM: Apps → IPC
You need to log in
before you can comment on or make changes to this bug.
Description
•