When you set a bookmark to be checked for updates, you have the option to notify you with an alert. That alert says... "Such and Such has been updated would you like to view it..." If you click yes to view it, you get a tiny titleless, contentless window in the upper left of your screen. I can't be sure when this broke, because the web site I have it check don't update that often. But I do think it happened a while ago once and I thought it was a fluke at the time. Steps to Reproduce: bookmark a page that changes somewhat frequently. set the bookmark to notify you when it changes with an alert. when the alert comes up click to view the page. Expected: A new window with the updated page appears Actual: a tiny worthless window (which is basically the empty titlebar alone) appears

First of all, How does someone get a bug confirmed around here???? But anyway, starting in the latest nightly... 20010503 I have been seeing this bug change. Instead of a tiny window with no content, I now see a giant (more than full screen) window with no chrome whatsoever. The page is displayed, but no links are underlined or colored. (they still work though) I am going to post a screenshot of what I am seeing. This bug completly breaks that bookmark feature for me.

added keywords, but would like someone to confirm

Art is a good way to get a bug confirmed.

nav pretriage: propose moving to mozilla0.9.2, nsbeta1+, P3.

I've attached a screenshot of the new behavior I am seeing now. The window that pops up is now enormous. (My resolution is 1280x1024 -- the window is just a little bit bigger, the scrollbars are off-screen) There is still no chrome, and links are not colorsed as links. Everytime the page in the screenshot has the word "here", it should be underlined and colored like a link. This is a pretty boring page normally, but other pages that do have backgrounds, text colors, etc. do work when brought up by the alert dialog. It is just the links that fail to format correctly. The cursor still turns to a hand over the links though. The author of this page didn't specify a title tag, so "|ue||ue||" appears. On pages with titles the title does appear.

nav triage team: Marking as per Vishy's pre-triage: nsbeta1+, p2, mozilla0.9.2

So this is because the code is opening a window with the document url, not a navigator.xul file with the document url as an argument. Fairly trivial to fix, but I've sent off email to danm to ask if there's a more official way of doing this that I can take advantage of.

Hm. I asked danm and he thought that the openWindow function on nsIWindowWatcher (which is what the code that opens this window uses) should be sufficient to open a chromed browser window with a url. Apparently not...

This patch corrects nsBookmarksService's use of nsIWindowWatcher::OpenWindow. Seems we need to pass a chrome url & doc to load as an argument. It'd be nice if there were some generic browser window opening function that'd get you a browser window no matter who implemented that, but whatever. Also, while I was here I fixed a couple of issues that was preventing the update-icon functionality from working (typo in jar.mn, got rid of some namespaces, added status="" attributes to appropriate places). Now (if selected) updated bookmarks in classic get a nice red sparkle on them. We probably want something similar in Modern.

Disregard the section in jar.mn that refers to linktag.css. It's old cruft.

also, disregard the DEBUG_BOOKMARK_PING_OUTPUT define. Removed in tree.

sr=blake with the stuff we talked about.

Also, nice job fixing this nsbeta1+'er, Ben! FANTASTIC!

Fixed.

VERIFIED Fixed