Closed
Bug 780508
Opened 12 years ago
Closed 12 years ago
Pymake: avoid spawning shell processes while compiling
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla17
People
(Reporter: rain1, Assigned: rain1)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
(deleted),
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
Two improvements: 1. In silent mode, we hook in an ELOG because GNU make doesn't print the command that failed. Pymake does, so the hook just creates unnecessary shell processes. 2. REPORT_BUILD causes a shell invocation for every single file build, and it can simply be replaced with $(info) since it's always the first command in a recipe.
Attachment #649131 -
Flags: review?(khuey)
Assignee | ||
Comment 1•12 years ago
|
||
This seems to speed up builds by around 2 minutes (4-5%) on my computer.
Assignee | ||
Updated•12 years ago
|
Attachment #649132 -
Flags: review?(ted.mielczarek) → review?(khuey)
Comment on attachment 649131 [details] [diff] [review] patch v1 Review of attachment 649131 [details] [diff] [review]: ----------------------------------------------------------------- Haha, nice.
Attachment #649131 -
Flags: review?(khuey) → review+
Attachment #649132 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 4•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/5804800a7009 I still need to check in the comm-central patch.
Whiteboard: [leave open]
Assignee | ||
Comment 9•12 years ago
|
||
http://hg.mozilla.org/comm-central/rev/914c29a1a1e3
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Updated•12 years ago
|
Whiteboard: [leave open]
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•