Bug 780329 added support for only a small subset of test suites in mozbuild. This bug tracks adding more, ideally all of them.

> 404 Not Found > > /tests/all was not found. is not a useful response to ./mach mochitest-plain

Comment on attachment 665577 [details] [diff] [review] Part a: Give _run_make append_env and explicit_env arguments Review of attachment 665577 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.

Comment on attachment 665579 [details] [diff] [review] Part b: Fix mochitest runners Review of attachment 665579 [details] [diff] [review]: ----------------------------------------------------------------- LGTM as long as you've tested that it works.

Comment on attachment 665580 [details] [diff] [review] Part c: Support mochitest-a11y, reftest, crashtest Review of attachment 665580 [details] [diff] [review]: ----------------------------------------------------------------- Aside from invalid comments and strings related to copying the mochitest's code, this looks good. ::: python/mozbuild/mozbuild/testing/reftest.py @@ +43,5 @@ > + top source directory, an absolute filename, or a directory containing > + test files. > + > + suite is the type of mochitest to run. It can be one of ('plain', > + 'chrome', 'browser'). Really? @@ +47,5 @@ > + 'chrome', 'browser'). > + """ > + > + if suite not in ('reftest', 'crashtest'): > + raise Exception('None or unrecognized mochitest suite type.') mochitest? ::: python/mozbuild/mozbuild/testing/test.py @@ +11,5 @@ > + > +class TestRunner(MozbuildObject): > + """Base class to share code for parsing test paths.""" > + > + def _parse_test_path(self, test_path): Thank you for consolidating this!

https://hg.mozilla.org/mozilla-central/rev/195e7907f7ba https://hg.mozilla.org/mozilla-central/rev/1b36381b4b6b https://hg.mozilla.org/mozilla-central/rev/111089855ef8