Closed
Bug 780824
Opened 12 years ago
Closed 8 years ago
Pymake may use special targets as default
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
In memory/jemalloc/src/Makefile.in, the default rule pymake decides to use is... .SUFFIXES.
$ cat > foo.mk <<EOF
.SUFFIXES:
@echo foo
bar:
@echo bar
$ make -f foo.mk
bar
$ python build/pymake/make.py -f foo.mk
foo
I think all .something rules are ignored by GNU make. (adding a .FOO rule doesn't make it the default, while obviously, .FOO has no meaning to GNU make)
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #649550 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #649550 -
Attachment is obsolete: true
Attachment #649550 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → mh+mozilla
|
|
Assignee | |
Comment 3•12 years ago
|
||
In fact, without this patch and without the patch for bug 777379, the default rule for most directories is .PRECIOUS.
|
||
Comment 4•12 years ago
|
||
Comment on attachment 649552 [details] [diff] [review]
Ignore all targets starting with a dot in pymake
Review of attachment 649552 [details] [diff] [review]:
-----------------------------------------------------------------
From browsing the gmake source, it looks like the actual rule here is "starts with a . and does not contain a / or \ ". r=me if we match the (admittedly insane) gmake behavior.
Attachment #649552 -
Flags: review?(ted.mielczarek) → review+
|
||
Comment 5•8 years ago
|
||
Mass close of pymake-related bugs.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•