Closed Bug 780990 Opened 12 years ago Closed 12 years ago

Give providers a way to not support uncached mode

Categories

(Calendar :: Internal Components, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

Details

Attachments

(1 file)

Attached patch Fix - v1 (deleted) — Splinter Review
Now that its easier for providers to support full offline mode we should head towards making providers use nothing but the cache. This patch removes the checkbox for the Cache when a new calendar property "cache.always" is set, and assumes the calendar is always cached in that case. I've also taken the liberty to fix part of bug 768207 with this patch by renaming the cache label to "Offline Support". I left out the on-by-default part though until later on. I'd like to rewrite the ICS provider and fix bug 700637 before we do that. I've tested cache-only providers in two cases and its going quite fine.
Attachment #649778 - Flags: review?(mohit.kanwal)
Comment on attachment 649778 [details] [diff] [review] Fix - v1 Review of attachment 649778 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Does not break anything. Have tested adding new calendars and works. ::: calendar/base/content/dialogs/calendar-properties-dialog.js @@ +12,1 @@ > Ha Ha! Nice!
Attachment #649778 - Flags: review?(mohit.kanwal) → review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.9
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: