Closed Bug 781307 Opened 12 years ago Closed 12 years ago

Remove make rules from services/

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla17

People

(Reporter: gps, Assigned: gps)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch Use generic rules, v1 (deleted) — Splinter Review
This is like bug 759487 but for all other Makefile.in's in services/. services/common/Makefile.in still has some rules for functionality I added a few months back to run some standalone test servers. But, the rules come after rules.mk, so I don't think it will be a problem. The new generic install rule rocks!
Attachment #650245 - Flags: review?(mh+mozilla)
Comment on attachment 650245 [details] [diff] [review] Use generic rules, v1 Review of attachment 650245 [details] [diff] [review]: ----------------------------------------------------------------- ::: services/aitc/Makefile.in @@ +23,5 @@ > $(NULL) > > PREF_JS_EXPORTS = $(srcdir)/services-aitc.js > > +AITC_MODULE_FILES := $(foreach module,$(aitc_modules),modules/$(module)) $(addprefix modules/,$(aitc_modules)) @@ +24,5 @@ > > PREF_JS_EXPORTS = $(srcdir)/services-aitc.js > > +AITC_MODULE_FILES := $(foreach module,$(aitc_modules),modules/$(module)) > +AITC_MODULE_DEST := $(FINAL_TARGET)/modules/services-aitc You don't need config.mk if you use =. ::: services/common/Makefile.in @@ +38,1 @@ > TESTING_JS_MODULES := $(foreach file,$(testing_modules),modules-testing/$(file)) Can you change this to use addprefix while you're here?
Attachment #650245 - Flags: review?(mh+mozilla) → review+
Assignee: nobody → gps
Whiteboard: [fixed in services]
Target Milestone: --- → mozilla17
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: