Closed
Bug 781390
Opened 12 years ago
Closed 12 years ago
Make barrier verifier testing work better with the methodjit
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: billm, Assigned: billm)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
While looking at bug 774859, I was trying to write a test case using the write barrier verifier and the methodjit. However, it turns out to be almost impossible to do that. We're supposed to invoke the operation callback in the methodjit when running with gczeal(4). However, each time we call StartVerifyPreBarriers, it calls setNeedsBarrier, which causes us to return to the interpreter.
This patch makes testing a little easier by always compiling with barriers when gczeal==4. That way we don't have to return to the interpreter each time we do Start/EndVerifyPreBarriers.
Attachment #650380 -
Flags: review?(bhackett1024)
|
||
Updated•12 years ago
|
Attachment #650380 -
Flags: review?(bhackett1024) → review+
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Looks like this (or a subset of) needs to be landed on mozilla-aurora to prevent bustage by the landing of the patch from bug 774859
You need to log in
before you can comment on or make changes to this bug.
Description
•