Closed
Bug 781956
Opened 12 years ago
Closed 12 years ago
<wizard/> : Using advance(pageId) on the last page should not close the wizard
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: wnayes, Assigned: wnayes)
References
Details
Attachments
(1 file)
(deleted),
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
I was trying to use advance() with a page ID parameter on the last page to send the user to a previous page. The use of goTo() is not a desired alternative, as it does not properly handle the page stack and makes the Back/Next buttons unreliable.
Expected: The wizard would jump to the page ID specified as an argument to advance().
Result: The wizard calls the method in "wizardfinish" and closes.
I believe a fix could be done with a single change at
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/wizard.xml#270
The existence of aPageId should also be checked with onLastPage to ensure that the wizard is really ready to finish and close.
I am new to patching Mozilla, so I may or may not be successful in creating one myself.
Assignee | ||
Comment 1•12 years ago
|
||
This adds a check to ensure that there is no page ID before closing the wizard when advancing backwards on the last page.
Attachment #651022 -
Flags: review?
Assignee | ||
Updated•12 years ago
|
Blocks: Instantbird
Updated•12 years ago
|
Attachment #651022 -
Flags: review? → review?(enndeakin)
Comment 2•12 years ago
|
||
Comment on attachment 651022 [details] [diff] [review]
Add a check for aPageId before closing the wizard
Thanks for the patch. I assume you don't have permission to check the patch in. In this case, you can set the 'checkin-needed' keyword on the bug and someone will check it in for you.
Attachment #651022 -
Flags: review?(enndeakin) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 3•12 years ago
|
||
Trivial enough to land without a Try push. Thanks for the patch, Will! You can confirm that this bug is fixed once it lands on mozilla-central (probably tomorrow morning).
https://hg.mozilla.org/integration/mozilla-inbound/rev/636c283ed0ed
Comment 4•12 years ago
|
||
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•