Closed
Bug 782235
Opened 12 years ago
Closed 12 years ago
move HTTP convenience functions to nsHttp
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: julian.reschke, Assigned: julian.reschke)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
julian.reschke
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Updated•12 years ago
|
QA Contact: julian.reschke
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #653189 -
Flags: review?(bsmith)
Comment 2•12 years ago
|
||
Comment on attachment 653189 [details] [diff] [review]
Proposed patch
Review of attachment 653189 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #653189 -
Flags: review?(bsmith) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 3•12 years ago
|
||
This doesn't apply cleanly. Please rebase. Also, please update your commit information to include your name along with your email address. Thanks!
Updated•12 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 4•12 years ago
|
||
Patch updated to apply to trunk, try results at https://tbpl.mozilla.org/?tree=Try&rev=0974a5ea2077
Attachment #653189 -
Attachment is obsolete: true
Attachment #664013 -
Flags: review?
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 664013 [details] [diff] [review]
Proposed patch
wrong patch - please ignore
Attachment #664013 -
Flags: review?
Assignee | ||
Comment 6•12 years ago
|
||
Patch rebased; try results at https://tbpl.mozilla.org/?tree=Try&rev=0974a5ea2077
Attachment #664013 -
Attachment is obsolete: true
Attachment #664015 -
Flags: review?(bsmith)
Assignee | ||
Comment 7•12 years ago
|
||
Comment on attachment 664015 [details] [diff] [review]
Proposed patch
Patch is just rebased version of https://bugzilla.mozilla.org/attachment.cgi?id=653189, r+'d by bsmith
Attachment #664015 -
Flags: review?(bsmith) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 8•12 years ago
|
||
(In reply to Julian Reschke from comment #6)
> https://tbpl.mozilla.org/?tree=Try&rev=0974a5ea2077
Green on Try. Thanks for rebasing!
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ebd4fc2448c
Comment 9•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•