Closed
Bug 782416
Opened 12 years ago
Closed 12 years ago
[Azure] convert gfx::2d from NULL to nullptr
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: nrc, Assigned: joe)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
nrc
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: ncameron → joe
Attachment #651830 -
Flags: review?(bas.schouten)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 651830 [details] [diff] [review]
do it
Review of attachment 651830 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/2d/gfx2d.vcxproj
@@ +117,5 @@
> </ItemGroup>
> <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
> <ImportGroup Label="ExtensionTargets">
> </ImportGroup>
> +</Project>
Not sure we need this change :) Saving the project in MSVC again might overwrite it!
Attachment #651830 -
Flags: review?(bas.schouten) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Target Milestone: --- → mozilla17
|
|
Assignee | |
Comment 4•12 years ago
|
||
backed out because I am a moron who doesn't know how to test his code
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ce9bc206a7d
Target Milestone: mozilla17 → ---
|
|
Assignee | |
Comment 5•12 years ago
|
||
Turns out that a bunch of 2d didn't support nullptr with only the previous patch. This patch fixes that.
Attachment #652174 -
Flags: review?(ncameron)
|
Reporter | |
Comment 6•12 years ago
|
||
Comment on attachment 652174 [details] [diff] [review]
put nullptr somewhere that works
Review of attachment 652174 [details] [diff] [review]:
-----------------------------------------------------------------
looks good
::: gfx/2d/2D.h
@@ +5,5 @@
>
> #ifndef _MOZILLA_GFX_2D_H
> #define _MOZILLA_GFX_2D_H
>
> +#include "Types.h"
I don't think you need this include, but if you _want_ it, then it is fine
Attachment #652174 -
Flags: review?(ncameron) → review+
|
|
Assignee | |
Comment 7•12 years ago
|
||
I want it!
|
|
Assignee | |
Comment 8•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Target Milestone: --- → mozilla17
|
||
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e00f4d16eeed
https://hg.mozilla.org/mozilla-central/rev/8f6b4e0bcef0
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•