Closed
Bug 782578
Opened 12 years ago
Closed 6 years ago
Logger.log.apply(Logger, ["foo"].concat(aMessageArgs)); pattern concats an array when debugging is disabled
Categories
(Core Graveyard :: Identity, defect)
Core Graveyard
Identity
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: MattN, Unassigned)
Details
(Quoting Justin Dolske [:Dolske] from bug 764213 comment #12)
> ::: browser/modules/SignInToWebsite.jsm
> @@ +19,5 @@
> > +XPCOMUtils.defineLazyModuleGetter(this, "Logger",
> > + "resource://gre/modules/identity/LogUtils.jsm");
> > +
> > +function log(...aMessageArgs) {
> > + Logger.log.apply(Logger, ["SignInToWebsiteUX"].concat(aMessageArgs));
>
> Wish we didn't do this, because it's generating garbage even when debugging
> is disabled. :(
|
||
Comment 1•12 years ago
|
||
I agree. I'd like to see this cleaned up, too.
|
||
Comment 2•6 years ago
|
||
See https://bugzilla.mozilla.org/show_bug.cgi?id=1497358; closing remaining open bugs in this component.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•