Closed
Bug 783103
Opened 12 years ago
Closed 12 years ago
Avoid layout flush from isElementVisible when attempting to focus the URL bar or search bar
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 17
People
(Reporter: dao, Assigned: dao)
References
Details
(Keywords: perf, Whiteboard: [snappy])
Attachments
(1 file)
|
(deleted),
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #652247 -
Flags: review?(gavin.sharp)
|
||
Comment 1•12 years ago
|
||
In which cases does isElementVisible(gURLBar) return false (assuming gURLBar is non-null)? Is that only when the url bar is on a hidden toolbar? Is gURLBar.focus() always guaranteed to be a no-op in all of those cases?
|
Assignee | |
Comment 2•12 years ago
|
||
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #1)
> In which cases does isElementVisible(gURLBar) return false (assuming gURLBar
> is non-null)? Is that only when the url bar is on a hidden toolbar?
That and in certain popups if dom.disable_window_open_feature.location is false.
> Is gURLBar.focus() always guaranteed to be a no-op in all of those cases?
Yes. However, gURLBar.focused can report true if the URL bar was focused when it got hidden and the user hasn't manually focused something else (bug 570835).
|
|
Assignee | |
Updated•12 years ago
|
Attachment #652247 -
Flags: review?(enndeakin)
|
||
Updated•12 years ago
|
Attachment #652247 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Updated•12 years ago
|
Attachment #652247 -
Flags: review?(enndeakin)
|
|
||
Comment 3•12 years ago
|
||
Of course, I meant to change flag for my name, not Gavin's
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
This patch caused Bug 784621.
You need to log in
before you can comment on or make changes to this bug.
Description
•