Closed
Bug 783614
Opened 12 years ago
Closed 12 years ago
Cutting a sub string from the location bar value can unexpectedly modify the value further
Categories
(Firefox :: Address Bar, defect)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 17
People
(Reporter: alice0775, Assigned: dao)
References
Details
Attachments
(2 files)
(deleted),
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/a79132ac2f05
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120817030555
Step To Reproduce:
1. Load this
2. Select text "s" of https://bugzilla.mozilla.org/...
3. Right click on the locationbar and execute Cut or Ctrl+x
Actual Results:
Locationbar shows bugzilla.mozilla.org/...
And caret is between z and i
Expected Results:
Locationbar should show http://bugzilla.mozilla.org/...
And the caret should be between p and :
And protocol scheme should not hide in the editing text in this case
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → dao
OS: Windows 7 → All
Hardware: x86 → All
Assignee | ||
Updated•12 years ago
|
Summary: Strange behavior of "Cut" in Locationbar → Cutting a sub string from the location bar value can unexpectedly modify the value further
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #652887 -
Flags: review?(bmcbride)
Comment 2•12 years ago
|
||
Comment on attachment 652887 [details] [diff] [review]
patch
Review of attachment 652887 [details] [diff] [review]:
-----------------------------------------------------------------
Code looks good, but it could really do with a test (see browser_bug556061.js).
Attachment #652887 -
Flags: review?(bmcbride) → review-
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #653431 -
Flags: review?(bmcbride)
Assignee | ||
Updated•12 years ago
|
Attachment #652887 -
Flags: review- → review?(bmcbride)
Updated•12 years ago
|
Attachment #653431 -
Flags: review?(bmcbride) → review+
Updated•12 years ago
|
Attachment #652887 -
Flags: review?(bmcbride) → review+
Updated•12 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Flags: in-testsuite+
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Comment 6•12 years ago
|
||
So now the text copied will be exactly what was selected?
E.g.: URL Bar shows: bugzilla.mozilla.org/show_bug.cgi?id=783614
"bugzilla.mozilla.org/show_bug.cgi?id=783614" is highlighted and copied
Text "bugzilla.mozilla.org/show_bug.cgi?id=783614" will be on the clipboard?
Previously text that had not been highlighted managed to end up in the clipboard.
Comment 7•12 years ago
|
||
No, this bug didn't change that behavior. This fixed a very specific case of cutting a substring of text from the location bar.
Comment 8•12 years ago
|
||
So the cut/copy function in Firefox is still broken. Awesome!
You need to log in
before you can comment on or make changes to this bug.
Description
•