Closed Bug 783644 Opened 12 years ago Closed 12 years ago

window.open(..., ..., "dialog=1") breaks on b2g. Preventing us from logging in to Marketplace app when run in-process

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-basecamp:+)

Status:
VERIFIED FIXED
Project Flags:
blocking-basecamp +

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

References

Details

(Keywords: smoketest, Whiteboard: [qa!])

Attachments

(3 files)

Part 1: Flip a pref so B2G ignores dialog=1 in window.open, like we do on other mobile platforms.
(deleted), patch
smaug
: review+
Details | Diff | Splinter Review
Part 2: If we're inside <iframe mozbrowser>, ignore the dialog=1 feature in window.open.
(deleted), patch
smaug
: review+
Details | Diff | Splinter Review
Part 3: Tests.
(deleted), patch
smaug
: review+
Details | Diff | Splinter Review
This is similar to but possibly different from bug 776086, which is about the Marketplace app failing when run /out of process/. But marking blocking bug 776086, since it could be the same issue. I can reproduce this on desktop and on my Otoro device.
Assignee: nobody → justin.lebar+bug
blocking-basecamp: --- → ?
Okay, the problem is that they're passing "dialog=1" in the window.open, and that causes us to bail with the regular window.open logic.
This may need bug 776129 to behave correctly. At least, when testing, you should test with that bug applied.
Depends on: 776129
This fixes the problem on B2G, but not on desktop. Even if we don't care about this working on desktop, we do care about being able to test it...
This fixes the problem everywhere. With this change, we don't need part 1, but I think we should keep part 1 for good measure.
Attached patch Part 3: Tests. (deleted) — — Splinter Review
This just modifies existing tests to pass dialog=1. Without this patch, these tests would open a whole new window, instead of doing the desired mozbrowser rigmarole.
Attachment #652892 - Flags: review?(bugs)
Attachment #652889 - Flags: review?(bugs)
Attachment #652891 - Flags: review?(bugs)
Blocks: browser-api
Whiteboard: [smoke-test-bustage]
Attachment #652889 - Flags: review?(bugs) → review+
Comment on attachment 652891 [details] [diff] [review] Part 2: If we're inside <iframe mozbrowser>, ignore the dialog=1 feature in window.open. huh, IsBelowContentBoundary sounds really odd. But that is not about this bug.
Attachment #652891 - Flags: review?(bugs) → review+
Attachment #652892 - Flags: review?(bugs) → review+
Summary: Can't log in to Marketplace app when run in-process, due to error in window.open. → window.open(..., ..., "dialog=1") breaks on b2g. Preventing us from logging in to Marketplace app when run in-process
> huh, IsBelowContentBoundary sounds really odd. I agree it's not great; suggestions are definitely welcome.
blocking-basecamp: ? → +
Whiteboard: [smoke-test-bustage] → [smoke-test-bustage], [qa+]
QA Contact: jsmith
Status: RESOLVED → VERIFIED
Whiteboard: [smoke-test-bustage], [qa+] → [smoke-test-bustage], [qa!]
Keywords: smoketest
Whiteboard: [smoke-test-bustage], [qa!] → [qa!]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: