_snprintf doesn't guarantee null-termination. Evil. Totally. Applies to nrappkit, and also to dtlsidentity.cpp in mtransport. Patch (not for upstreaming probably) attached. Needs to be tried on windows.

I mentioned this on #media, but there is a MSVC CRT API you can use: _snprintf_s. Unfortunately you have to pass _TRUNCATE as one of the parameters to make it work properly, so you can't just #define the problem away. I wrote (without testing) a possible inline snprintf implementation we could use: int snprintf(char *buffer, size_t n, const char *format, ...) { va_list argp; int ret; va_start(argp, fmt); ret = vsnprintf_s(buffer, n, _TRUNCATE, format, argp); va_end(argp); return ret; }

Comment on attachment 652958 [details] [diff] [review] Patch for snprintf Review of attachment 652958 [details] [diff] [review]: ----------------------------------------------------------------- ::: media/mtransport/third_party/nrappkit/src/port/win32/include/csi_platform.h @@ +53,5 @@ > #include <r_types.h> > > #define strcasecmp _stricmp > #define strncasecmp _strnicmp > +#define snprintf PR_snprintf I'd rather not pull NSPR in here.... Let's just write a new wrapped version of snprintf() and put it in util/util.c Do you need me to do that?

I fixed up jesup's patch to use the snprintf implementation I pasted above.