Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla] Reporter
	Description • 12 years ago

1) Open Firefox
2) Click the overflow options menu.
3) Select "Add-ons"
4) Long press the marketplace icon

Expected: Nothing happens
Actual: A context menu pops up requesting to share or save image

Text selection occurs if you long press the title, "Your Add-ons".

Same thing occurs in the web apps page.

	Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla] Reporter
	Comment 1 • 12 years ago

These pages are written in xhtml (ex: https://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutApps.xhtml) so I think they would have to be special-cased to remove these extra interactions.

	Wesley Johnston (:wesj)
	Comment 2 • 12 years ago

We support pages disabling context menus. Listen for "contextmenu" events on the document and call aEvent.preventDefault().

	Wesley Johnston (:wesj)
	Comment 3 • 12 years ago

Oh wait, that won't kill text selection will it... maybe it should.

	Wesley Johnston (:wesj)
	Comment 4 • 12 years ago

We should also test things like user-select during selection:

https://developer.mozilla.org/en-US/docs/CSS/user-select

	:Margaret Leibovic
	Comment 5 • 10 years ago

Using -moz-user-select: none; addresses this issue, but I'm not sure if it's actually a problem that we allow text selection in about:addons/about:apps/about:downloads.

Robin, do you have an opinion here? It would be an easy patch to write.

	Robin Andersen [:tecgirl]
	Comment 6 • 10 years ago

Well, if we get 1058243 to work then that icon won't show up anymore since it takes you to AMO instead of "Your Add-ons", anyway. 

If it persists, then it should not have long-press function, especially when long-pressing is trying to copy the icon and the text in the next cell (for me, the title of the first Add-on I have installed). We should probably disable long-press for that entire cell.

	:Margaret Leibovic
	Comment 7 • 10 years ago

(In reply to Robin Andersen [:tecgirl] from comment #6)
> Well, if we get 1058243 to work then that icon won't show up anymore since
> it takes you to AMO instead of "Your Add-ons", anyway. 
> 
> If it persists, then it should not have long-press function, especially when
> long-pressing is trying to copy the icon and the text in the next cell (for
> me, the title of the first Add-on I have installed). We should probably
> disable long-press for that entire cell.

I interpret this bug as a more general issue of whether or not to enable text selection on the entire about: pages. Disabling text selection would make it feel a bit more "native", and that's actually what desktop does in their about:addons, so maybe we should go ahead with that.

Long press will still bring up context menus on the individual add-ons, but that's more expected, because the options there are things like "Disable" and "Uninstall".

	Mike Taylor [:miketaylr] Assignee
	Comment 8 • 9 years ago

I think we should disable text selection to be consistent with what Desktop does. If we do this in aboutBase.css, these are the affected pages:

aboutAccounts
aboutAddons, desktop can’t do selection
aboutDevices, need to be careful to not disable selection of the IP input.
aboutDownloads, desktop can’t do selection
aboutLogins, selection doesn't make much sense because clicking brings up a context menu with all the useful stuff IMO.

	Mike Taylor [:miketaylr] Assignee
	Comment 9 • 9 years ago

Margaret, do you mind reviewing?

	:Margaret Leibovic
	Comment 10 • 9 years ago

This issue also came up in bug 1177520, so I want to make sure Barbara is aware of this.

However, I agree with the assessment in comment 8, let's be consistent with desktop.

	:Margaret Leibovic
	Comment 12 • 9 years ago

Comment on attachment 8666595 [details] [diff] [review]
784222.-Make-non-input-text-unselectable-for-abo.patch

Review of attachment 8666595 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks for being thorough about checking where this file is used.

	Mike Taylor [:miketaylr] Assignee
	Comment 13 • 9 years ago

Thanks! I had some selection robocop tests go orange, but they're green after retriggering.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b78a0c6f2db

	Mike Taylor [:miketaylr] Assignee
	Comment 14 • 9 years ago

Updating commit message to reflect r=margaret.

	Pulsebot
	Comment 15 • 9 years ago

https://hg.mozilla.org/integration/fx-team/rev/ce5a761f544f

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 16 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/ce5a761f544f