Closed Bug 784922 Opened 12 years ago Closed 12 years ago

Package TCPSocket.{js|manifest) to fix: TEST-UNEXPECTED-FAIL | /tests/dom/network/tests/test_tcpsocket_enabled_no_perm.html | navigator.mozTCPSocket should be accessible if dom.mozTCPSocket.enabled is true

Categories

(SeaMonkey :: Build Config, defect, P2)

Product:
SeaMonkey
Component:
Build Config
Type:
defect

Tracking

(seamonkey2.14 fixed)

Status:
VERIFIED FIXED
Milestone:
seamonkey2.15
Tracking Flags:
Tracking Status
seamonkey2.14 --- fixed

People

(Reporter: philip.chee, Assigned: sgautherie)

References

(Blocks 1 open bug)

Details

(Whiteboard: [perma-orange])

Attachments

(1 file)

(Av1) Package TCPSocket.{js|manifest), Reorder a part of removed-files.in [Checked in: Comment 3]
(deleted), patch
Callek
: review+
Callek
: approval-comm-aurora+
Details | Diff | Splinter Review
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1345674832.1345677240.26708.gz TEST-UNEXPECTED-FAIL | /tests/dom/network/tests/test_tcpsocket_enabled_no_perm.html | navigator.mozTCPSocket should be accessible if dom.mozTCPSocket.enabled is true TEST-UNEXPECTED-FAIL | /tests/dom/network/tests/test_tcpsocket_enabled_with_perm.html | navigator.mozTCPSocket should be accessible if dom.mozTCPSocket.enabled is true TEST-UNEXPECTED-FAIL | /tests/dom/network/tests/test_tcpsocket_enabled_with_perm.html | an unexpected uncaught JS exception reported through window.onerror - TypeError: navigator.mozTCPSocket is Caused by Bug 733573 - Expose a client TCP socket API to web applications Also see TB http://hg.mozilla.org/comm-central/rev/04b378637986 Add TCPSocket.js/.manifest to packaged files to fix xpcshell bustage after bug 733573 landed in m-c. r+a=bustage-fix
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #654566 - Flags: review?(bugspam.Callek)
Blocks: SmTestFail
Severity: normal → major
Priority: -- → P2
Whiteboard: [perma-orange]
Target Milestone: --- → seamonkey2.14
Comment on attachment 654566 [details] [diff] [review] (Av1) Package TCPSocket.{js|manifest), Reorder a part of removed-files.in [Checked in: Comment 3] Review of attachment 654566 [details] [diff] [review]: ----------------------------------------------------------------- I'm going to rs+ this on the basis that serge has been pretty on-point with these files, and I already took far too long to review this
Attachment #654566 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 654566 [details] [diff] [review] (Av1) Package TCPSocket.{js|manifest), Reorder a part of removed-files.in [Checked in: Comment 3] https://hg.mozilla.org/comm-central/rev/1e74e0c88d8e [Approval Request Comment] No risk, I was just too slow to check this patch in.
Attachment #654566 - Attachment description: (Av1) Package TCPSocket.{js|manifest), Reorder a part of removed-files.in → (Av1) Package TCPSocket.{js|manifest), Reorder a part of removed-files.in [Checked in: Comment 3]
Attachment #654566 - Flags: approval-comm-aurora?
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
status-seamonkey2.14: --- → affected
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: seamonkey2.14 → seamonkey2.15
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1346782230.1346783362.19848.gz WINNT 5.2 comm-central-trunk debug test mochitests-2/5 on 2012/09/04 11:10:30 V.Fixed. (m-2 is green again ;-))
Status: RESOLVED → VERIFIED
Comment on attachment 654566 [details] [diff] [review] (Av1) Package TCPSocket.{js|manifest), Reorder a part of removed-files.in [Checked in: Comment 3] Review of attachment 654566 [details] [diff] [review]: ----------------------------------------------------------------- I'm going to rs+ this on the basis that serge has been pretty on-point with these files, and I already took far too long to review this
Attachment #654566 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: