Closed
Bug 785929
Opened 12 years ago
Closed 11 years ago
Remove mContentRect from FrameMetrics
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: drs, Assigned: kats)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ajones
:
review+
|
Details | Diff | Splinter Review |
mContentRect on FrameMetrics seems pretty useless. Not only can it be calculated from mCSSContentRect, but it's also not always completely up to date. We should remove it.
Assignee | ||
Comment 1•11 years ago
|
||
For the record, I also think that mContentRect is being calculated incorrectly in APZC. At [1], mContentRect is assigned a value that is the CSS page size /divided by/ the resolution. All the code that uses this, and the other bits at [2] that set this value all do CSS page size /multiplied by/ the resolution (or equivalent).
I'm building a patch to get rid of this less-than-useless variable as it caused me to waste most of my day.
[1] https://hg.mozilla.org/mozilla-central/file/58bf49390ed4/gfx/layers/ipc/AsyncPanZoomController.cpp#l835
[2] https://hg.mozilla.org/mozilla-central/file/58bf49390ed4/layout/base/nsDisplayList.cpp#l664
Assignee: nobody → bugmail.mozilla
Depends on: 879004
Assignee | ||
Comment 2•11 years ago
|
||
Fairly confident I updated all the calculations appropriately. Try push in progress at https://tbpl.mozilla.org/?tree=Try&rev=37616b14a0f5
Attachment #760598 -
Flags: review?(ajones)
Updated•11 years ago
|
Attachment #760598 -
Flags: review?(ajones) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•