Closed
Bug 785974
Opened 12 years ago
Closed 12 years ago
IonMonkey: Handle JSOP_URSH with known double type without bailouts
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
(Whiteboard: [ion:p2])
Attachments
(1 file)
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
The patch renames LShiftOp to LShiftI and adds LUrshD for handling x >>> y with known double type. I haven't tested the ARM code yet; I will send to try before landing.
Bug 750947 will also help here, but I'd like to land this much simpler patch first, since x >>> 0 is common in (Emscripten-)generated code.
Attachment #655674 -
Flags: review?(dvander)
Comment 1•12 years ago
|
||
(In reply to Jan de Mooij [:jandem] from comment #0)
>
> Bug 750947 will also help here, but I'd like to land this much simpler patch
> first, since x >>> 0 is common in (Emscripten-)generated code.
It's common in Mandreel-generated code too, so this will help with Octane (Mandreel test) as well.
Updated•12 years ago
|
Attachment #655674 -
Flags: review?(dvander) → review+
Updated•12 years ago
|
Whiteboard: [ion:p2]
Assignee | ||
Comment 2•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 3•12 years ago
|
||
Should this show a speedup on the emscripten tests on awfy?
You need to log in
before you can comment on or make changes to this bug.
Description
•