Closed
Bug 786003
Opened 12 years ago
Closed 12 years ago
Fix file handle leak in nsDOMFileReader, add tests to IndexedDB
Categories
(Core :: Storage: IndexedDB, defect)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
Tests use ArchiveReader and streaming from a Blob via XHR.
Attachment #655705 -
Flags: review?(jst)
|
||
Updated•12 years ago
|
Attachment #655705 -
Flags: review?(jst) → review+
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
Sorry, backed out because of timeouts in test_blob_simple.html on all Windows builds:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7f0beb46374
https://tbpl.mozilla.org/php/getParsedLog.php?id=14757220&tree=Mozilla-Inbound
The timeout happens right at the start of the test, so I'd guess it's caused by something in test_blob_archive.html (rather than the changes to test_blob_simple.html itself).
|
|
Assignee | |
Updated•12 years ago
|
Summary: Add a few extra tests for blobs in IndexedDB → Fix file handle leak in nsDOMFileReader, add tests to IndexedDB
|
|
Assignee | |
Comment 3•12 years ago
|
||
Turns out that the problem was in nsDOMFileReader. It holds blobs and the channel (which holds the input stream via its hash bag) alive past the load event. Then the file handle stays open until CC gets it.
Patch has r=jst.
Attachment #655705 -
Attachment is obsolete: true
Attachment #656023 -
Flags: review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•