This is a color conversion regression in Nightly build 2012-08-27. The pushlog from build 08-26 to 08-27 is: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b3cce81fef1a&tochange=8af6a22827ec This bug is likely a regression from this changeset for bug 767480: https://hg.mozilla.org/mozilla-central/rev/f26d6c5a2d93

Same issue on the Galaxy Note 1 with hardware playback. Video is green with flickering in and out of non-green.

This bug is a regression from bug 767480: https://hg.mozilla.org/mozilla-central/rev/f26d6c5a2d93 That fix inadvertently moved some pointer math out of CopyPlane()'s loops. Because the aSrc and aDst pointers where not advanced, the Cb and Cr planes were not copied for color formats that hit CopyPlane()'s slow path. This patch fixes the green videos, but does not address related bug 785275.

Comment on attachment 659068 [details] [diff] [review] advance-aSrc-aDst-pointers.patch Review of attachment 659068 [details] [diff] [review]: ----------------------------------------------------------------- oops

Comment on attachment 659068 [details] [diff] [review] advance-aSrc-aDst-pointers.patch [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 767480 (which regressed Nightly 18 and Aurora 17) User impact if declined: H264 videos may be green on some Android devices Testing completed (on m-c, etc.): m-c Risk to taking this patch (and alternatives if risky): Low risk. This patch just reverts a copy/paste typo in a video color conversion function. String or UUID changes made by this patch: N/A