<formletter>It has been decreed (or requested at any rate) that our release (read non-debug) builds must not print anything to the console when the app is running. See bug 76720 for details. I have done a preliminary tree scouring and created mini-patches for each module that has bare printfs. These patches are not all inclusive as I didn't even think about xul/js output until post scour so module owners & peers will still need to scour their modules themselves as well as make sure the preliminary patches do not break anything.</formletter>

Sorry about the additional spammage but I should clear up a couple of things before everyone starts replying. 1) I'm just the messenger. Discussions outside of the specific module/patches should be discussed in the parent bug ( bug 76720). 2) I have no intention of checking in the patches as is; that's why the bugs are assigned to someone else ;). 3) The patches are the result of a far & wide-reaching grep across the entire tree. They may affect some cases that are not even used and they are far from optimal. 4) Some platforms/ports will not need the printfs shutoff as they use other mechanisms to stop the printfs. That's fine. Note it in the bug and close it as invalid(?). Depending upon the platform/port some people may still be interested in removing the overhead from the printfs.

Per PDT Triage effort: changing the targeted milestone to "mozilla0.9.2". Please feel free to renominate/address bug if time is available AFTER all currently targeted 0.9.1 bugs are resolved. .Angela...

76720 is targetted for 0.9.1. can this be moved up?

lets keep dribbling these [console] bugs into the tree as quick as we can, but they shouldn't hold up or block 0.9.1 so moving the target milestone to 0.9.2.

->jtaylor

Wrt attach 38009: In the modules/libimg/src/if.cpp portion of the patch, the entire |if (num000+num255 == header->width*header->height)| block should be enclosed in the debug ifdef as there's no possible side effect of that if being evaluated.

r=cls on attach 38968 & 38010

sr=tor on attach 38968 & 38010

a=dbaron for trunk checkin (on behalf of drivers)

jat's checkin for this bug has been backed out, as he managed to introduce win32 line endings.

Fix checked in today.

Fix checked in, resolving.

Verified fix checked into lxr.mozilla.org