User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.1 (KHTML, like Gecko) Chrome/21.0.1180.83 Safari/537.1 Steps to reproduce: Open www.usopen.com Close it In another tab, start typing usopen. Autocomplete completes it to usopen.com Press Ctrl+Shift+Enter to go to usopen.org Actual results: usopen.com it loaded Expected results: usopen.org is loaded

@Loic - I want to work on this bug. Can it be assigned to me?

Comment on attachment 656750 [details] [diff] [review] Prevent default visit to .com when autocomplete is on and ctrl+shift+enter or shift+enter is pressed rb - I'm not required as an reviwer on this.

I think this is basically the same of bug 448486, there is patch there as well, quite similar to this one, though bug 448486 comment 10 is valid for all the patches here and there, this should be handled browser-side, not toolkit side, since the special modifiers behavior is not toolkit related. If you want to post a new patch please do there, or coordinate with the other contributor. Thank you.

Comment on attachment 656747 [details] [diff] [review] Prevent default visit to .com when autocomplete is on and ctrl+shift+enter or shift+enter is pressed >diff -r 50e4ff05741e toolkit/content/widgets/autocomplete.xml >--- a/toolkit/content/widgets/autocomplete.xml Wed Aug 15 21:37:36 2012 -0400 >+++ b/toolkit/content/widgets/autocomplete.xml Thu Aug 30 10:22:20 2012 +0530 >@@ -484,16 +484,18 @@ > break; > case KeyEvent.DOM_VK_RETURN: > #ifdef XP_MACOSX > // Prevent the default action, since it will beep on Mac > if (aEvent.metaKey) > aEvent.preventDefault(); > #endif > this.mEnterEvent = aEvent; >+ if (aEvent.ctrlKey || aEvent.shiftKey) >+ this.mController.handleEscape(); > cancel = this.mController.handleEnter(false); > break; > case KeyEvent.DOM_VK_DELETE: > #ifdef XP_MACOSX > case KeyEvent.DOM_VK_BACK_SPACE: > if (aEvent.shiftKey) > #endif > cancel = this.mController.handleDelete();

ehr, wait, you are the same user, so please keep the good work there :)

@mak - I thought these two can be treated as separate bugs. I am new to firefox development, so I need some guidance. Do you suggest I need to make changes to urlbarBindings.xml in browser directory?

(In reply to rb from comment #8) > @mak - I thought these two can be treated as separate bugs. I am new to > firefox development, so I need some guidance. Do you suggest I need to make > changes to urlbarBindings.xml in browser directory? yes. I think the 2 bugs end up going through the same (or related) code, so we can likely handle them in one bug. If in the end the other bug shouldn't solve both issues we may evaluate to reopen this one.