Closed
Bug 78662
Opened 24 years ago
Closed 23 years ago
[console] mac widgets & rhapsody timer should not print to console in opt build
Categories
(Core :: XUL, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla0.9.8
People
(Reporter: cls, Assigned: mikepinkerton)
References
Details
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
<formletter>It has been decreed (or requested at any rate) that our release
(read non-debug) builds must not print anything to the console when the app is
running. See bug 76720 for details. I have done a preliminary tree scouring
and created mini-patches for each module that has bare printfs. These patches
are not all inclusive as I didn't even think about xul/js output until post
scour so module owners & peers will still need to scour their modules themselves
as well as make sure the preliminary patches do not break anything.</formletter>
Sorry about the additional spammage but I should clear up a couple of things
before everyone starts replying.
1) I'm just the messenger. Discussions outside of the specific module/patches
should be discussed in the parent bug ( bug 76720).
2) I have no intention of checking in the patches as is; that's why the bugs are
assigned to someone else ;).
3) The patches are the result of a far & wide-reaching grep across the entire
tree. They may affect some cases that are not even used and they are far from
optimal.
4) Some platforms/ports will not need the printfs shutoff as they use other
mechanisms to stop the printfs. That's fine. Note it in the bug and close it
as invalid(?). Depending upon the platform/port some people may still be
interested in removing the overhead from the printfs.
Assignee | ||
Comment 5•23 years ago
|
||
\/\/hatever
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.3
Comment 6•23 years ago
|
||
76720 is targetted for 0.9.1, can we move this up?
Comment 7•23 years ago
|
||
lets keep dribbling these [console] bugs into the tree as quick as we
can, but they shouldn't hold up or block 0.9.1 so moving the target milestone
to 0.9.2.
Target Milestone: mozilla0.9.3 → mozilla0.9.2
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.2 → mozilla1.0
Comment 8•23 years ago
|
||
Is this something we still need? (noting that there have been no additional
comments in the bug since 5/15)
Assignee | ||
Comment 9•23 years ago
|
||
while we don't need this for the cfm build (we stub out printf to a no-op), we
will need this for the mach-o build.
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla1.0 → mozilla0.9.8
Comment 10•23 years ago
|
||
marking fixed. mac timers no longer exist.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•