Pymake doesn't spin up a shell for the signing command while building the installer. Since this command contains a few MSYS-style paths inherited from MOZ_SIGN_CMD (set in the environment by buildbot), things don't quite work out. I had a look at what it would take to fix buildbot. It needs both toolsdir and basedir set to a Windows-style path. Seems like some sorts of builds do have that, some don't, and I don't want to dig in and find out why -- this is much easier. Is there a better way to force Pymake to use a shell? I'll take either ted's or gps's review.

Comment on attachment 656677 [details] [diff] [review] patch Review of attachment 656677 [details] [diff] [review]: ----------------------------------------------------------------- The hack, it burns. I guess this will fit right in with the rest of the packaging code!

Pushed to build-system: https://hg.mozilla.org/projects/build-system/rev/31f60d0435cd

Comment on attachment 656677 [details] [diff] [review] patch Review of attachment 656677 [details] [diff] [review]: ----------------------------------------------------------------- There are probably other ways to do this, but I'm not going to lose sleep over it, since hopefully this will all go away in bug 780561.

Comment on attachment 656677 [details] [diff] [review] patch post-hoc r+

(In reply to Ted Mielczarek [:ted] from comment #4) > There are probably other ways to do this, but I'm not going to lose sleep > over it, since hopefully this will all go away in bug 780561. Note that package signature is out of scope for bug 780561. But further packager changes will make this go away.

Comment on attachment 656677 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): not a regression User impact if declined: we'll still need to keep using GNU make for a year from now Testing completed (on m-c, etc.): Yes Risk to taking this patch (and alternatives if risky): Zero risk. Trivial patch. String or UUID changes made by this patch: None.

Comment on attachment 656677 [details] [diff] [review] patch [Triage Comment] Very low risk, Callek let us know that if anything seems fishy we can easily back this out.