Closed
Bug 787654
Opened 12 years ago
Closed 12 years ago
Zune and Royale have wrong window color with draw in title bar
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird17 fixed)
RESOLVED
FIXED
Thunderbird 18.0
| Tracking | Status | |
|---|---|---|
| thunderbird17 | --- | fixed |
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
(Keywords: ux-consistency)
Attachments
(2 files)
|
(deleted),
patch
|
andreasn
:
review+
andreasn
:
ui-review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
|
(deleted),
image/png
|
Details |
screenshot
From bug 755793 comment 49:
> Created attachment 657201 [details]
> mail.tabs.drawInTitlebar enabled with Zune Desktop Theme
>
> Just wanted to note that drawing in titlebar causes unreadable visuals
> with the official Zune theme [1].
>
> [1]: http://go.microsoft.com/fwlink/?LinkID=75078
It look I didn't used the official themes (there are a lot of them around). I haven't found a official DL link for Royale but the one I now used looks most "official".
|
Assignee | |
Comment 1•12 years ago
|
||
Patch setting individual colors instead using the system colors which don't match the border colors.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #657553 -
Flags: ui-review?(nisses.mail)
Attachment #657553 -
Flags: review?(nisses.mail)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Screenshot for easier UI-review. On top Zune active window, second with inactive window, third Royale activ and the last inactive.
|
||
Comment 3•12 years ago
|
||
Comment on attachment 657553 [details] [diff] [review]
patch
Looks good!
Attachment #657553 -
Flags: ui-review?(nisses.mail)
Attachment #657553 -
Flags: ui-review+
Attachment #657553 -
Flags: review?(nisses.mail)
Attachment #657553 -
Flags: review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Updated•12 years ago
|
Attachment #657553 -
Attachment is patch: true
|
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
|
|
Assignee | |
Comment 5•12 years ago
|
||
Comment on attachment 657553 [details] [diff] [review]
patch
[Approval Request Comment]
Regression caused by (bug #): 755793
User impact if declined: only visual, hard readable tabs
Risk to taking this patch (and alternatives if risky): no high risk, it's only color change through CSS.
If approval + I'll add a patch which applies cleanly.
Attachment #657553 -
Flags: approval-comm-aurora?
|
|
Assignee | |
Comment 6•12 years ago
|
||
This patch applies on comm-aurora. So no need for a special patch.
|
||
Updated•12 years ago
|
Attachment #657553 -
Flags: approval-comm-aurora? → approval-comm-aurora+
|
||
Comment 7•12 years ago
|
||
status-thunderbird17:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•