Vincent Chang[:vchang][changyihsin] Assignee
	Description • 12 years ago

Netd's 1xx message indicates that the requested command was initiated; expect another reply before proceeding with a new command. For instance, if we send "interface list" command, we may receive several 1xx responses from netd. The command is complete until we receive 2xx, 4xx and 5xx response.   
 
Network Worker: Preparing to send 'interface list' command...
Network Worker: Sending 'interface list' command to netd.
Network Worker: Receiving 'interface list' command response from netd.
Network Worker:           ==> Code: 110  Reason: lo
Network Worker: Receiving 'interface list' command response from netd.
Network Worker:           ==> Code: 110  Reason: rmnet0
...
Network Worker: Receiving 'interface list' command response from netd.
Network Worker:           ==> Code: 110  Reason: ip6tnl0
Network Worker: Receiving 'interface list' command response from netd.
Network Worker:           ==> Code: 200  Reason: Interface list completed

	Philipp von Weitershausen [:philikon]
	Comment 1 • 12 years ago

This seems like an important fix to prevent races or premature returns to the main threads, so I guess this should block? Vincent, please clarify. Tentatively nom'ing for blocking.

	Vincent Chang[:vchang][changyihsin] Assignee
	Comment 2 • 12 years ago

Support netd's 1xx response message.

	Philipp von Weitershausen [:philikon]
	Comment 4 • 12 years ago

(In reply to Philipp von Weitershausen [:philikon] from comment #1)
> This seems like an important fix to prevent races or premature returns to
> the main threads, so I guess this should block? Vincent, please clarify.
> Tentatively nom'ing for blocking.

Vincent, can you please clarify whether this fix is an absolutely must-have for shipping the phone?

	Vincent Chang[:vchang][changyihsin] Assignee
	Comment 5 • 12 years ago

There are four netd commands using 1xx responses. They are     
"interface list"          => list network interfaces. 
"tether interface list 0" => list tethering interfaces.
"tether dns list 0"       => list dns forwarding addresses 
"list_ttys"               => list tty devices

We don't use these commands for tethering. But it is nice to fix it 
so that we can support these netd commands. I don't think this fix 
is a must-have for shipping the phone.

	Andrew Overholt [:overholt]
	Comment 6 • 12 years ago

Thanks, Vincent.  Not a blocker.

	Philipp von Weitershausen [:philikon]
	Comment 7 • 12 years ago

Comment on attachment 658427 [details] [diff] [review]
Support 1xx message

Review of attachment 658427 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/net_worker.js
@@ +42,5 @@
>  
>  importScripts("systemlibs.js");
>  
> +function netdResponseType(code) {
> +  // 1xx

How about

  function netdResponseType(code) {
    return Math.floor(code / 100);
  }

r=me with that :)

	Vincent Chang[:vchang][changyihsin] Assignee
	Comment 8 • 12 years ago

Updated the patch to address comment 7.

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 12 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2bd4bc59452

	Ed Morley [:emorley]
	Comment 10 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/a2bd4bc59452