Closed Bug 788165 Opened 12 years ago Closed 12 years ago

Breakpoint arrow does not change to green when the debugger breaks on that line.

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 21

People

(Reporter: Optimizer, Assigned: jaws)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached image Blue icon on a broken line (deleted) —
STR are simple. 1. Open any page (tested on more than 10) 2. Open debugger. 3. Select a script and create a breakpoint that is likely to hit. 4. Refresh the page. 5. Control stops on the set line, but the blue circular icon does not change to green pointed arrow. 6. Clicking any other entry from the stacklist changes the highlighted line and also the pointer to green. Latest Nightly build (3rd Sep.) Windows 7 x64. Aero.
Known issue. See bug 735725. Thanks for your report Girish!
Depends on: 735725
OS: Windows 7 → All
Hardware: x86_64 → All
We'll probably get to bug 735725 before bug 762979.
No longer depends on: 762979
Priority: -- → P3
Attached patch WIP Patch (obsolete) (deleted) — Splinter Review
Mihai, this gets the debugLocation icon placed on top of the breakpoint. I made it a little smaller in this case so that the user can still see the breakpoint icon behind it. I am not sure how annotationHTML.task is used, so I didn't change that line, but it would be easy to make it match the debugLocation and breakpoint changes. Does this look good enough to you?
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #708225 - Flags: feedback?(mihai.sucan)
Comment on attachment 708225 [details] [diff] [review] WIP Patch This looks good - thank you! .task is used for lines with TODO - you can test it. Please update the patch for Linux and Macs.
Attachment #708225 - Flags: feedback?(mihai.sucan) → feedback+
Attached patch Patch (deleted) — Splinter Review
I give up on trying to get .task to work with TODO. I tried //TODO, // todo, //XXX, // ToDo but none of them got any special annotation. Either way, I made the changes assuming that it would work if I knew what I was doing :)
Attachment #708225 - Attachment is obsolete: true
Attachment #709922 - Flags: review?(mihai.sucan)
(In reply to Jared Wein [:jaws] from comment #6) > Created attachment 709922 [details] [diff] [review] > Patch > > I give up on trying to get .task to work with TODO. I tried //TODO, // todo, > //XXX, // ToDo but none of them got any special annotation. Hmm, maybe I didn't enable this Orion feature. > Either way, I made the changes assuming that it would work if I knew what I > was doing :) Thank you!
Comment on attachment 709922 [details] [diff] [review] Patch Thanks for the patch!
Attachment #709922 - Flags: review?(mihai.sucan) → review+
Whiteboard: [land-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 21
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: