Closed
Bug 788416
Opened 12 years ago
Closed 12 years ago
Remove ancient and unused tests in toolkit\mozapps\extensions\test\unit
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: Unfocused, Assigned: Unfocused)
Details
Attachments
(1 file)
(deleted),
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
Sooo... turns out toolkit\mozapps\extensions\test\unit still exists, and contains tests for the old Add-ons Manager. ie, before The Great Rewrite(tm).
This may come as a shock, but I propose removing that directory.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #658397 -
Flags: review?(dtownsend+bugmail)
Comment 2•12 years ago
|
||
Comment on attachment 658397 [details] [diff] [review]
Patch v1
Review of attachment 658397 [details] [diff] [review]:
-----------------------------------------------------------------
So I originally left these in place because I thought they were issues that still needed testing even in the new world order. I think that's probably not true for bug 356370 but the other two I think it'd be nice to be tested. Will we ever remember to add tests if we remove these files? Probably not. Will we ever remember to add tests if we leave these files here? Probably not.
Attachment #658397 -
Flags: review?(dtownsend+bugmail) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Indeed. At the very least, removing them from the tree saves time/effort, as people are currently still trying to update them (bug 758950, bug 759642, etc).
https://hg.mozilla.org/integration/fx-team/rev/8d83eefa874f
Whiteboard: [fixed-in-fx-team]
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•