Closed Bug 788418 Opened 12 years ago Closed 12 years ago

Image error is unreadable against dark background

Categories

(Toolkit :: Themes, defect)

Product:
Toolkit
Component:
Themes
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla18
Tracking Flags:
Tracking Status
firefox15 --- wontfix
firefox16 --- verified
firefox17 --- verified

People

(Reporter: mxn, Assigned: dao)

References

(
URL
)

Details

(Keywords: regression)

Attachments

(2 files)

unreadable-error.png
(deleted), image/png
Details
patch
(deleted), patch
jaws
: review+
Gavin
: approval-mozilla-aurora+
akeybl
: approval-mozilla-beta+
Details | Diff | Splinter Review
Attached image unreadable-error.png (deleted) —
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:17.0) Gecko/17.0 Firefox/17.0 Build ID: 20120903042010 Steps to reproduce: Opened a broken image, such as: data:image/png, Actual results: The “cannot be displayed” error message is black against the dark gray background. Expected results: The error message should have been white or near white for better readability. This is a regression caused by the following changesets: https://hg.mozilla.org/mozilla-central/rev/836e451c8b77 https://hg.mozilla.org/mozilla-central/rev/35ac9dfcef9b
Blocks: 754539
Status: UNCONFIRMED → NEW
Component: Untriaged → Layout
Depends on: 376997
Ever confirmed: true
OS: Mac OS X → All
Product: Firefox → Core
Hardware: x86 → All
Assignee: nobody → jaws
Blocks: 756419
No longer blocks: 754539
Component: Layout → Themes
No longer depends on: 376997
Keywords: regression
Product: Core → Toolkit
Attached patch patch (deleted) — — Splinter Review
Assignee: jaws → dao
Status: NEW → ASSIGNED
Attachment #659219 - Flags: review?(dolske)
URL: data:image/png,
Comment on attachment 659219 [details] [diff] [review] patch Review of attachment 659219 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/themes/winstripe/global/TopLevelImageDocument.css @@ +12,2 @@ > background-color: #fff; > color: #222; Why does the tag name need to be specified here?
Attachment #659219 - Flags: review?(dolske) → review+
(In reply to Jared Wein [:jaws] from comment #2) > ::: toolkit/themes/winstripe/global/TopLevelImageDocument.css > @@ +12,2 @@ > > background-color: #fff; > > color: #222; > > Why does the tag name need to be specified here? It makes the code more readable. The class by itself isn't as descriptive.
https://hg.mozilla.org/mozilla-central/rev/0b6afc4c7b06
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Comment on attachment 659219 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 756419 User impact if declined: unreadable errors for some invalid images Testing completed (on m-c, etc.): manual on m-c Risk to taking this patch (and alternatives if risky): low risk String or UUID changes made by this patch: none
Attachment #659219 - Flags: approval-mozilla-aurora?
Attachment #659219 - Flags: approval-mozilla-beta?
Attachment #659219 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 659219 [details] [diff] [review] patch Sounds like regressions (if any) could be wontfix'd. Approving for Beta.
Attachment #659219 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Keywords: verifyme
Reproduced the issue on FF 16b3. Verified fixed on FF 16b4 on Win 7 x64, Ubuntu 12.04 and Mac OS X 10.7.4.
status-firefox16: fixed → verified
Verified fixed on FF 17b1 on Win 7 x64, Ubuntu 12.04 and Mac OS X 10.6.8.
Status: RESOLVED → VERIFIED
status-firefox17: fixed → verified
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: