Closed
Bug 788603
Opened 12 years ago
Closed 12 years ago
[B2G] all mochitests using bidi_numeral_test.js fail in OOP mode
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: jgriffin, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
All of the layout tests which use the file tests/layout/base/tests/bidi_numeral_test.js are failing when run in B2G because they're not OOP-compatible. They set prefs directly (http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/bidi_numeral_test.js#42) instead of using SpecialPowers.
These tests will be disabled for B2G runs until they can be updated. The approximate list is here: http://mxr.mozilla.org/mozilla-central/search?string=bidi_numeral_test.js
Comment 1•12 years ago
|
||
It seems simpler to just fix the test, no?
Comment 2•12 years ago
|
||
Attachment #658664 -
Flags: review?(roc)
Attachment #658664 -
Flags: review?(roc) → review+
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ec21394970c
What needs to happen to get these un-disabled?
Reporter | ||
Comment 4•12 years ago
|
||
(In reply to David Baron [:dbaron] from comment #3)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/2ec21394970c
>
> What needs to happen to get these un-disabled?
I'll take care of it once I see this hit m-c.
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Reporter | ||
Comment 6•12 years ago
|
||
Affected tests have been re-enabled for b2g. Thanks for the fix!
You need to log in
before you can comment on or make changes to this bug.
Description
•