Closed
Bug 788645
Opened 12 years ago
Closed 12 years ago
TabChild::Init returns bool instead of nsresult
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: ayg, Assigned: ayg)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Bug 781725 added two "return false;" lines to TabChild::Init(). This has the effect of returning NS_OK, since it actually returns nsresult, not bool. Probably returning NS_ERROR_FAILURE or something would be better.
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: nobody → ayg
Attachment #658840 -
Flags: review?(bugs)
|
||
Updated•12 years ago
|
Attachment #658840 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/090511685ed4
Win64 is still red on that try after retriggering, but it seems very unlikely to be related to this, and anyway I have another push with this patch where Win64 is green:
https://tbpl.mozilla.org/?tree=Try&rev=09d179dea7c3
Flags: in-testsuite-
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
|
||
Updated•12 years ago
|
Component: DOM: Mozilla Extensions → DOM
|
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•