Closed
Bug 788754
Opened 12 years ago
Closed 12 years ago
Simplify SourceClient's API for its consumers
Categories
(DevTools :: Debugger, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 18
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
They should just be able to get the source as a string and not have to worry about tokens or whether it was sent as a long string, etc.
|
||
Updated•12 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•12 years ago
|
||
Try push, please, Panos :)
|
||
Comment 2•12 years ago
|
||
|
|
||
Comment 3•12 years ago
|
||
The Windows-only xpcshell test failures are also present in a try push without this patch, but with the patches from bug 755661.
|
|
||
Comment 4•12 years ago
|
||
Comment on attachment 665914 [details] [diff] [review]
v1
Review of attachment 665914 [details] [diff] [review]:
-----------------------------------------------------------------
Nice API polish!
Attachment #665914 -
Flags: review?(past) → review+
|
|
||
Comment 5•12 years ago
|
||
New try run on top of the new patch for bug 755661: https://tbpl.mozilla.org/?tree=Try&rev=8f65b0cafb05
|
|
||
Comment 6•12 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 18
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•