Closed Bug 78920 Opened 23 years ago Closed 23 years ago

clicking on toggle offline widget no longer works

Categories

(SeaMonkey :: MailNews: Backend, defect, P1)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.1

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Details

(Keywords: regression, Whiteboard: [nsbeta1+])

Attachments

(1 file)

clicking on the toggle offline widget no longer takes you offline, making it harder to test offline :-( Investigating...
Status: NEW → ASSIGNED
Keywords: nsbeta1, regression
OS: Windows 2000 → All
Priority: -- → P1
Hardware: PC → All
marking nsbeta1+
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.9.1
Attached patch proposed fix (deleted) — Splinter Review
Can I get an r= and an sr=? With this fix, the offline widget works again, and since we're using the apps init method, we get tooltips and the correct startup state. There might be a better place to put this js call, but I'm not familiar enough with the way our js is structured. Ideally, it would get called whenever a mail/news window is opened.
looks good to me. does it work in stand alone msg window and the 3 pane? sr=sspitzer
let me see if there is a better place to put the init call...
the stand alone message window, the three pane and the alt 3 pane have onload handlers. all 3 onload handlers call the function you put the js call. so it's good stuff. sr=sspitzer
QA Contact: esther → gchan
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
testing commercial builds 2001052904 on Win NT 4.0 2001052908 on Linux 2.2 2001052908 on MAC OS 9.0.4 Verifying that clicking the offline indicator is working in the following list: a.Browser b.Composer/Editor page c.Mail/news compose window d.Messenger window e.Separate message window f.Separate newsgroup window g.search messages window h.address book window i.history window j.subscribe to newsgroups window I am not verifying it is in sync with other options such as File|Work offline, etc.. If this is incorrect please let me know. Testing on all 3 platforms, I noticed that clicking the offline widget does not work in the following windows: -history window -subscribe to newsgroups window -search messages window But for all other windows it works fine. Not sure if the widget is supposed to be in those 3 windows that if fails in. If they are not or we don't care about those widget status in those 3 windows, then we can mark this bug valid. otherwise I'll wait for one of the senior people here to advise what is supposed to happen next.
gchan, there should be a known bug about those 3 windows. (I think I logged it.)
Yup you're right Seth. It's bug 80970 So can I mark this bug as Verified? Or does it depend on the other 3 windows being fixed first?
this bug got over-shadowed by other fixes to the offline widget, so bienvenu's fix and the subsequent fixes have made it so the general problem is fixed. gchan: based on your comments in this bug, I'd verify this bug and add yourself to the history / search / subscribe offline indicator bugs. shout out to my peeps: laurel also logged a bug for offline indicator problems in search / subscribe. (I added a comment to her bug a few minutes ago.)
marking bug as verifed.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: