Closed
Bug 789546
Opened 12 years ago
Closed 12 years ago
data:image gif saved as file "index" without a filename extension, no longer as file "index.gif"
Categories
(Core Graveyard :: File Handling, defect)
Tracking
(firefox17 unaffected, firefox18+ fixed)
RESOLVED
FIXED
mozilla18
| Tracking | Status | |
|---|---|---|
| firefox17 | --- | unaffected |
| firefox18 | + | fixed |
People
(Reporter: cpeterson, Assigned: jdm)
References
()
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
ehsan.akhgari
:
review+
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
This bug was forked from bug 254139 comment 62.
STR:
1. View a data:image URI such as:
data:image/gif;base64,R0lGODlhEAAOALMAAOazToeHh0tLS/7LZv/0jvb29t/f3//Ub//ge8WSLf/rhf/3kdbW1mxsbP//mf///yH5BAAAAAAALAAAAAAQAA4AAARe8L1Ekyky67QZ1hLnjM5UUde0ECwLJoExKcppV0aCcGCmTIHEIUEqjgaORCMxIC6e0CcguWw6aFjsVMkkIr7g77ZKPJjPZqIyd7sJAgVGoEGv2xsBxqNgYPj/gAwXEQA7
2. Right-click on the tiny image and `Save Image As`
AR:
Starting with Nightly 18.0a1 (2012-09-01), Firefox saves a file called "index" (with no ".gif" filename extension).
ER:
Before Nightly 2012-09-01, Firefox saved a file called "index.gif" with a proper filename extension. (The base filename is "index" because the data:image does not have its own name or title).
Here is the regression range from Nightly 08-31 to 09-01:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fcc533f691e9&tochange=a21fd4d085ad
|
||
Comment 1•12 years ago
|
||
The first bad revision is:
changeset: 104038:bdc68f5ddb38
user: Josh Matthews <josh@joshmatthews.net>
date: Tue Jun 26 00:20:12 2012 -0400
summary: Bug 722861 - Add privacy information to image requests, and use a separate cache for private requests. r=joe
Blocks: 722861
|
|
||
Updated•12 years ago
|
tracking-firefox18:
--- → ?
|
||
Updated•12 years ago
|
|
|
||
Comment 2•12 years ago
|
||
jdm, are you planning to look into this?
|
Assignee | |
Comment 3•12 years ago
|
||
Yes; I've just been on a stealth vacation this week.
Assignee: nobody → josh
|
|
Assignee | |
Comment 4•12 years ago
|
||
Argh, I totally forgot to look for JS users of the image cache and change their uses of getService.
|
|
Assignee | |
Comment 5•12 years ago
|
||
I'm testing this patch as we speak.
|
|
Assignee | |
Comment 6•12 years ago
|
||
Attachment #661817 -
Flags: review?(ehsan)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #661766 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•12 years ago
|
||
|
|
Assignee | |
Comment 8•12 years ago
|
||
Comment on attachment 661817 [details] [diff] [review]
Convert all JS users of imgICache service to use privacy-aware imgITools API instead.
Matt, can you approve the mobile changes in this patch?
Attachment #661817 -
Flags: review?(mbrubeck)
|
||
Updated•12 years ago
|
Attachment #661817 -
Flags: review?(mbrubeck) → review+
|
||
Updated•12 years ago
|
Attachment #661817 -
Flags: review?(ehsan) → review+
|
|
||
Comment 10•12 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → mozilla18
|
|
||
Comment 11•12 years ago
|
||
Does that fix bug 789909 too?
|
||
Comment 12•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•